Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: Tom Tromey <tromey@redhat.com>,
	       "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	       "markus.t.metzger@gmail.com" <markus.t.metzger@gmail.com>,
	       "palves@redhat.com" <palves@redhat.com>,
	       "pmuldoon@redhat.com" <pmuldoon@redhat.com>
Subject: Re: [PATCH 1/1] gdb, python: update threads in Inferior.threads ()
Date: Thu, 26 Jul 2012 08:43:00 -0000	[thread overview]
Message-ID: <20120726084228.GB16614@host2.jankratochvil.net> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B2307AC6060@IRSMSX102.ger.corp.intel.com>

On Thu, 26 Jul 2012 09:49:44 +0200, Metzger, Markus T wrote:
> > Otherwise looks good to me.
> 
> Thanks. Who would be the approver of the change?

I believe Tom approved it this way.

BTW instead of those two runto calls it would be cheaper to:

gdb_breakpoint "check_threads"
gdb_continue_to_breakpoint "check_threads" ".* pthread_barrier_wait .*"

and

gdb_breakpoint [gdb_get_line_number "Break here."]
gdb_continue_to_breakpoint "Break-here" {.* Break here\. .*}

(The second parameter to gdb_continue_to_breakpoint is not mandatory.)

Otherwise you do the whole spawn of gdbserver 2 more times.


Thanks,
Jan


  reply	other threads:[~2012-07-26  8:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-25  8:27 markus.t.metzger
2012-07-25 16:15 ` Tom Tromey
2012-07-26  7:51   ` Metzger, Markus T
2012-07-26  8:43     ` Jan Kratochvil [this message]
2012-07-26  8:49       ` Metzger, Markus T
  -- strict thread matches above, loose matches on Subject: below --
2012-07-26 12:20 markus.t.metzger
2012-07-24  8:12 markus.t.metzger
2012-07-24 14:36 ` Phil Muldoon
2012-07-19 15:30 markus.t.metzger
2012-07-19 18:41 ` Jan Kratochvil
     [not found]   ` <2832024D-3061-4A13-BBF5-656C504C295D@gmail.com>
2012-07-24  8:08     ` Metzger, Markus T
2012-07-25 16:13       ` Tom Tromey
2012-07-26  5:51         ` Metzger, Markus T
2012-07-25 16:16   ` Tom Tromey
2012-07-06  9:50 markus.t.metzger
2012-07-06 18:12 ` Tom Tromey
2012-07-19 15:27   ` Metzger, Markus T
2012-07-18 13:54 ` Jan Kratochvil
2012-07-19 15:27   ` Metzger, Markus T
2012-07-19 18:45     ` Jan Kratochvil
2012-07-20  7:57       ` Metzger, Markus T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120726084228.GB16614@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@gmail.com \
    --cc=markus.t.metzger@intel.com \
    --cc=palves@redhat.com \
    --cc=pmuldoon@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox