From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22779 invoked by alias); 25 Jul 2012 20:11:59 -0000 Received: (qmail 22747 invoked by uid 22791); 25 Jul 2012 20:11:56 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_XC,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Jul 2012 20:11:41 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6PKBHhi004276 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 Jul 2012 16:11:17 -0400 Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6PKBDRL014348 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 25 Jul 2012 16:11:16 -0400 Date: Wed, 25 Jul 2012 20:11:00 -0000 From: Jan Kratochvil To: Philippe Waroquiers Cc: Joel Brobecker , gdb-patches@sourceware.org, Pedro Alves Subject: Re: [patch] [i386] Put hlt at the ON_STACK breakpoint [Re: GDB 7.4.91 available for testing] Message-ID: <20120725201107.GA32326@host2.jankratochvil.net> References: <20120722173053.GA22036@host2.jankratochvil.net> <1342983655.2301.55.camel@soleil> <20120723072125.GA12958@host2.jankratochvil.net> <20120723155951.GA24718@adacore.com> <20120723163513.GA1222@host2.jankratochvil.net> <1343074047.2209.23.camel@soleil> <20120723201611.GA19567@host2.jankratochvil.net> <1343075809.2209.53.camel@soleil> <20120725144858.GB24718@adacore.com> <1343246641.2240.8.camel@soleil> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1343246641.2240.8.camel@soleil> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00581.txt.bz2 On Wed, 25 Jul 2012 22:04:01 +0200, Philippe Waroquiers wrote: > IIUC, Jan's patch was to have GDB storing a hlt after the place > where GDBSERVER will put 0xCC. Not after, all the storage happens for the same byte. hlt is stored there by memory write, int3 is stored there by Z0. > What Valgrind needs is to have GDB storing the 0xCC > (the hlt will then have no positive nor negative impact on Valgrind). I will put 0xcc == int3 there although I believe valgrind could decode hlt (or even nop) the same way. Thanks, Jan