From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-92959-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28366 invoked by alias); 20 Jul 2012 18:10:28 -0000
Received: (qmail 28354 invoked by uid 22791); 20 Jul 2012 18:10:27 -0000
X-SWARE-Spam-Status: No, hits=-6.3 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Jul 2012 18:10:13 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6KIADom009839	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Fri, 20 Jul 2012 14:10:13 -0400
Received: from host2.jankratochvil.net (ovpn-116-30.ams2.redhat.com [10.36.116.30])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6KIA99d024925	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 20 Jul 2012 14:10:12 -0400
Date: Fri, 20 Jul 2012 18:10:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 01/10] change gdb to refcount bfd everywhere
Message-ID: <20120720181006.GA25555@host2.jankratochvil.net>
References: <87vchk3lxs.fsf@fleche.redhat.com> <20120719141750.GB23801@host2.jankratochvil.net> <871uk6wg14.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <871uk6wg14.fsf@fleche.redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00415.txt.bz2

On Fri, 20 Jul 2012 18:31:19 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> I personally disagree about the returned value from gdb_bfd_ref
> Jan> being useful, it makes the code more magic IMO (plus it is not much
> Jan> compatible with the narrow GNU Coding Standard code formatting).
> 
> I made this change.
> Let me know what you think.

I cannot do a real review now but I like this calling convention FYI.


Thanks,
Jan