From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25006 invoked by alias); 18 Jul 2012 10:36:08 -0000 Received: (qmail 24848 invoked by uid 22791); 18 Jul 2012 10:36:07 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,SPF_FAIL,TW_BJ X-Spam-Check-By: sourceware.org Received: from gbenson.demon.co.uk (HELO gbenson.demon.co.uk) (80.177.220.214) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Jul 2012 10:35:36 +0000 Date: Wed, 18 Jul 2012 10:36:00 -0000 From: Gary Benson To: Jan Kratochvil Cc: Sergio Durigan Junior , gdb-patches@sourceware.org Subject: Re: [RFA 3/4] Improved linker-debugger interface Message-ID: <20120718103533.GA2679@redhat.com> Mail-Followup-To: Jan Kratochvil , Sergio Durigan Junior , gdb-patches@sourceware.org References: <20120712123406.GA29236@redhat.com> <20120712123554.GD29236@redhat.com> <20120717215641.GA10049@host2.jankratochvil.net> <20120718070227.GA30859@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120718070227.GA30859@host2.jankratochvil.net> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00255.txt.bz2 Jan Kratochvil wrote: > On Wed, 18 Jul 2012 01:42:12 +0200, Sergio Durigan Junior wrote: > > I was considering suggesting the removal of the `gdb_assert' > > calls, and instead make it a simple check and return properly > > if the OBJFILE does not support probes. > > > > unsigned > > get_probe_argument_count (struct objfile *objfile, struct probe *probe) > > { > > if (objfile->sf == NULL || objfile->sf->sym_probe_fns == NULL) > > return 0; > > > > return objfile->sf->sym_probe_fns->sym_get_probe_argument_count (objfile, > > probe); > > } > > > > It would cover the case when OBJFILE does not support probe and > > would not be less safe. > > In fact why 'struct probe' does not contain its 'struct objfile *'? > It does not make sense to pass probe with different objfile. So the > parameter 'objfile' should not be passed at all. That would certainly simplify my code. Sergio, is this possible to do? Cheers, Gary -- http://gbenson.net/