From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-92798-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27275 invoked by alias); 18 Jul 2012 07:02:50 -0000
Received: (qmail 27267 invoked by uid 22791); 18 Jul 2012 07:02:49 -0000
X-SWARE-Spam-Status: No, hits=-6.2 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Jul 2012 07:02:34 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6I72YDR013948	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 18 Jul 2012 03:02:34 -0400
Received: from host2.jankratochvil.net (ovpn-116-30.ams2.redhat.com [10.36.116.30])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6I72UkH002977	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 18 Jul 2012 03:02:33 -0400
Date: Wed, 18 Jul 2012 07:02:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 3/4] Improved linker-debugger interface
Message-ID: <20120718070227.GA30859@host2.jankratochvil.net>
References: <20120712123406.GA29236@redhat.com> <20120712123554.GD29236@redhat.com> <20120717215641.GA10049@host2.jankratochvil.net> <m3pq7uneej.fsf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3pq7uneej.fsf@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00254.txt.bz2

On Wed, 18 Jul 2012 01:42:12 +0200, Sergio Durigan Junior wrote:
> I was considering suggesting the removal of the `gdb_assert' calls, and
> instead make it a simple check and return properly if the OBJFILE does
> not support probes.
> 
>     unsigned
>     get_probe_argument_count (struct objfile *objfile, struct probe *probe)
>     {
>       if (objfile->sf == NULL || objfile->sf->sym_probe_fns == NULL)
>         return 0;
> 
>       return objfile->sf->sym_probe_fns->sym_get_probe_argument_count (objfile,
>                                                                        probe);
>     }
> 
> It would cover the case when OBJFILE does not support probe and would
> not be less safe.

In fact why 'struct probe' does not contain its 'struct objfile *'?  It does
not make sense to pass probe with different objfile.  So the parameter
'objfile' should not be passed at all.


Thanks,
Jan