From: Anton Blanchard <anton@samba.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Add multiple branches to single step through atomic sequence testcase
Date: Mon, 16 Jul 2012 06:43:00 -0000 [thread overview]
Message-ID: <20120716164332.0bf00210@kryten> (raw)
In-Reply-To: <20120613160613.GI18729@adacore.com>
Hi Joel,
> I won't pretend I understand PowerPC code all that well, I only know
> the basics. My only concern with this change is whether you might have
> reduced the number of conditions being tested. I would have expected
> this patch to *add* more code, and associated changes in the .exp
> file. But apparently, the code update is sufficient. How does the
> change work? I see two labels used twice, for instance?
We don't have to update the .exp file because the entire larx/stcx
appears as a single stepi, regardless of what we put inside it. I added
the duplicate labels to test the duplicate branch detection in the
previous patch:
+ /* Check for duplicated breakpoints. */
+ for (index2 = 0; index2 < index; index2++)
The gdb single step code has always handled this but since I was
shifting code around I figured it was a good idea to test it.
Anton
next prev parent reply other threads:[~2012-07-16 6:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 3:56 [PATCH 1/3] Fix ppc64 single step over " Anton Blanchard
2012-06-06 3:57 ` [PATCH 2/3] Support up to 3 conditional branches in an atomic sequence Anton Blanchard
2012-06-13 16:02 ` Joel Brobecker
2012-07-16 6:34 ` Anton Blanchard
2012-09-28 10:44 ` Joel Brobecker
2012-09-28 11:44 ` Pedro Alves
2012-06-06 3:58 ` [PATCH 3/3] Add multiple branches to single step through atomic sequence testcase Anton Blanchard
2012-06-13 16:06 ` Joel Brobecker
2012-07-16 6:43 ` Anton Blanchard [this message]
2012-09-28 10:44 ` Joel Brobecker
2012-06-11 19:33 ` [PATCH 1/3] Fix ppc64 single step over " Joel Brobecker
2012-06-12 12:45 ` Anton Blanchard
2012-06-12 13:06 ` Luis Gustavo
2012-06-12 13:17 ` Joel Brobecker
2012-06-12 13:28 ` Luis Gustavo
2012-06-12 16:53 ` Edjunior Barbosa Machado
2012-06-13 0:46 ` Anton Blanchard
2012-06-13 14:00 ` Edjunior Barbosa Machado
2012-06-13 15:37 ` Joel Brobecker
2012-07-16 6:23 ` Anton Blanchard
2012-09-26 23:21 ` Edjunior Barbosa Machado
2012-09-27 19:03 ` Luis Gustavo
2012-09-28 10:16 ` Joel Brobecker
2013-07-29 7:39 Anton Blanchard
2013-07-29 7:41 ` [PATCH 3/3] Add multiple branches to single step through " Anton Blanchard
2013-08-01 15:55 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120716164332.0bf00210@kryten \
--to=anton@samba.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox