RE: [patch] MI telnet service

Abid, Hafiz
2012-07-12T14:45:24Z

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Eli Zaretskii
> Sent: Thursday, July 12, 2012 2:29 PM
> To: Abid, Hafiz
> Cc: gdb-patches@sourceware.org
> Subject: Re: [patch] MI telnet service
>
> > From: "Abid, Hafiz" <Hafiz_Abid@mentor.com>
> > Date: Thu, 12 Jul 2012 11:20:36 +0000
> >
> > This patch provides implementation of telnet service. This is based
> on initial work by Grigory Tolstolytkin.(http://sourceware.org/ml/gdb-
> patches/2011-11/msg00466.html)
>
> Thanks. A few comments about the documentation part:
>
> > +Start a telnet service on the given port. After the service is
> started,
> ^^
> Two spaces between sentences, please (here and elsewhere, including in
> comments to C code).
>
> > +user can connect to the gdb via telnet and execute CLI commands in
> ^^^
> "@value{GDBN}" instead of a literal "gdb".
>
> > +new one. For telnet service to work, @value{GDBN}
> > +should be configured with --enable-gdbmitel=yes.
>
> Use @option for options, like this: @samp{--enable-gdbmitel=yes}.
>
> Btw, why does it make sense to require a configure-time option for
> this feature? why not include it by default?
It just felt a bit safer to keep it optional. If community thinks that it is useful feature then I see no problem in making it available by default.

Thanks,
Abid