Re: [patch] MI telnet service

Eli Zaretskii
2012-07-12T13:29:42Z

> From: "Abid, Hafiz" <Hafiz_Abid@mentor.com>
> Date: Thu, 12 Jul 2012 11:20:36 +0000
>
> This patch provides implementation of telnet service. This is based on initial work by Grigory Tolstolytkin.(http://sourceware.org/ml/gdb-patches/2011-11/msg00466.html)

Thanks. A few comments about the documentation part:

> +Start a telnet service on the given port. After the service is started,
^^
Two spaces between sentences, please (here and elsewhere, including in
comments to C code).

> +user can connect to the gdb via telnet and execute CLI commands in
^^^
"@value{GDBN}" instead of a literal "gdb".

> +new one. For telnet service to work, @value{GDBN}
> +should be configured with --enable-gdbmitel=yes.

Use @option for options, like this: @samp{--enable-gdbmitel=yes}.

Btw, why does it make sense to require a configure-time option for
this feature? why not include it by default?