From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28772 invoked by alias); 15 Jul 2012 08:13:48 -0000 Received: (qmail 28758 invoked by uid 22791); 15 Jul 2012 08:13:43 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 15 Jul 2012 08:13:29 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6F8DP48007690 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 15 Jul 2012 04:13:25 -0400 Received: from host2.jankratochvil.net (ovpn-116-25.ams2.redhat.com [10.36.116.25]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6F8DKdv019142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 15 Jul 2012 04:13:23 -0400 Date: Sun, 15 Jul 2012 08:13:00 -0000 From: Jan Kratochvil To: "Abid, Hafiz" Cc: Gary Benson , "gdb-patches@sourceware.org" Subject: Re: [patch] MI telnet service Message-ID: <20120715081319.GA5019@host2.jankratochvil.net> References: <20120712131930.GG29236@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00199.txt.bz2 On Thu, 12 Jul 2012 16:36:43 +0200, Abid, Hafiz wrote: > I thought we are not required to follow the convention in the test program > source. Anyway, I will fix it with the rest. Thanks for reviewing. Like it is not worth to for example fix indentation in the existing testcases. But checking in a new testcase with very different formatting style does not make it easily fixable/update-able later. At least run indent with the options from GNU Coding Standard: -nbad -bap -nbc -bbo -bl -bli2 -bls -ncdb -nce -cp1 -cs -di2 -ndj -nfc1 -nfca -hnl -i2 -ip5 -lp -pcs -psl -nsc -nsob Thanks, Jan