From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2296 invoked by alias); 12 Jul 2012 20:30:47 -0000 Received: (qmail 2281 invoked by uid 22791); 12 Jul 2012 20:30:46 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Jul 2012 20:30:29 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6CKURmL003977 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 12 Jul 2012 16:30:28 -0400 Received: from host2.jankratochvil.net (ovpn-116-25.ams2.redhat.com [10.36.116.25]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6CKUNLl020391 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 12 Jul 2012 16:30:26 -0400 Date: Thu, 12 Jul 2012 20:30:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: gdb-patches@sourceware.org, tromey@redhat.com, palves@redhat.com Subject: Re: [RFA] Fix inconsistency in blockvector addrmap vs non-addrmap handling Message-ID: <20120712203023.GA26552@host2.jankratochvil.net> References: <20120605011446.670FD1E123B@ruffy2.mtv.corp.google.com> <20120622193539.GA7344@host2.jankratochvil.net> <20120624183352.GA15915@host2.jankratochvil.net> <20120703125419.GA14860@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00168.txt.bz2 On Thu, 12 Jul 2012 07:19:30 +0200, Doug Evans wrote: > I was playing with a case of "pc 0x42 in read in psymtab, but not in > symtab" case today. > gdb has other problems that get in the way, but having more > consistency between partial and full syms has to be a good thing. Therefore considering it as an agreement/approval of the patch. Therefore I will check it in tomorrow with no reply. > [btw, seems kinda odd to have two addrmaps: one for psymtabs/index and > one for fullsyms. I wonder if there's an opportunity here.] > > Here's an updated version of your patch to match the current tree. > > 2012-07-11 Jan Kratochvil > Doug Evans > > * buildsym.c (end_symtab_1): Split it to ... > (end_symtab_get_static_block): ... this ... > (end_symtab_from_static_block): ... and this function. > (end_symtab, end_expandable_symtab): Call them. > * buildsym.h (end_symtab_get_static_block) > (end_symtab_from_static_block): New declarations. > * dwarf2read.c (process_full_comp_unit): New variable static_block. > Set its valid CU ranges. Thanks, Jan