From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25058 invoked by alias); 22 Jun 2012 16:41:01 -0000 Received: (qmail 24876 invoked by uid 22791); 22 Jun 2012 16:40:59 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Jun 2012 16:40:47 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5MGeWNE028195 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 22 Jun 2012 12:40:33 -0400 Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5MGeTwG001177 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 22 Jun 2012 12:40:31 -0400 Date: Fri, 22 Jun 2012 16:41:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: Doug Evans , gdb-patches@sourceware.org Subject: Re: Branching time + 1 week (was: "Re: Three weeks to branching (gdb 7.5 release)") Message-ID: <20120622164028.GA8457@host2.jankratochvil.net> References: <20120511181737.GP29339@adacore.com> <20120611153435.GH2687@adacore.com> <20120621202023.GE2799@adacore.com> <20120622144641.GA4254@host2.jankratochvil.net> <20120622163224.GJ2799@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120622163224.GJ2799@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00714.txt.bz2 On Fri, 22 Jun 2012 18:32:24 +0200, Joel Brobecker wrote: > > Added two patches but those seem to be done although still discussed with Eli: > > > > * [Jan] auto-load safe-path: Permit shell wildcards > > http://sourceware.org/ml/gdb-patches/2012-06/msg00700.html > > Do I understand correctly that the first patch would have no impact > if we adopted the (rather-large-but-what-can-we-do) gnulib import? > If that's correct, we could move this patch off the critical path. There are: Re: [patch 1/2] auto-load safe-path: Permit shell wildcards http://sourceware.org/ml/gdb-patches/2012-06/msg00700.html [patch 2/2] [mingw+non-GNU?] gnulib fnmatch for libiberty/ FNM_FILE_NAME bugs http://sourceware.org/ml/gdb-patches/2012-06/msg00558.html [patch 1/2] works perfectly fine on GNU/Linux without [patch 2/2]. [patch 2/2] has no effect anywhere without [patch 1/2]. But the new functionality of [patch 1/2] behaves incorrectly on non-GNU/Linux systems without [patch 2/2]. TBH I do not think auto-load safe-path functionality is of much concern on non-GNU/Linux systems at all but to keep all correct... Also before checking-in [patch 2/2] I am going to update gnulib files as [obv] to separate gnulib update vs. gnulib addition of fnmatch-gnu module. I could add fnmatch-gnu from a several months old gnulib snapshot but that sems incorrect to me. gnulib update also seems safe enough to me (WDYT?). Thanks, Jan