From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8578 invoked by alias); 20 Jun 2012 15:47:43 -0000 Received: (qmail 8563 invoked by uid 22791); 20 Jun 2012 15:47:41 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Jun 2012 15:47:26 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5KFlPaX018043 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 20 Jun 2012 11:47:25 -0400 Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5KFlLM2027533 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 20 Jun 2012 11:47:23 -0400 Date: Wed, 20 Jun 2012 15:47:00 -0000 From: Jan Kratochvil To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [1/2][PATCH v3] Expand bitpos and type.length to LONGEST and ULONGEST Message-ID: <20120620154720.GA2468@host2.jankratochvil.net> References: <20120606235335.7fa94030@spoyarek> <20120606213420.GA9219@host2.jankratochvil.net> <20120608141636.GA24175@host2.jankratochvil.net> <20120608152735.GA26491@host2.jankratochvil.net> <20120611182346.1b8d872b@spoyarek> <20120611125933.GA7733@host2.jankratochvil.net> <20120612000336.5dfcc246@spoyarek> <20120612095543.GA10148@host2.jankratochvil.net> <20120612143432.GA24369@host2.jankratochvil.net> <20120618160027.67b2034c@spoyarek> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120618160027.67b2034c@spoyarek> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00635.txt.bz2 On Mon, 18 Jun 2012 12:30:27 +0200, Siddhesh Poyarekar wrote: > * Remove blocks that do not record changes, i.e. of the type: > > --- 8< ----- > LOC... | > foo... |=> Remove this. > bar... | > --- 8< ----- > [ -+]LOC... BTW these are already removed by "locdiff" itself, why another pass? > If these changes are OK, then I'll record my review on the resultant > locdiff.processed.out, which is 2330 lines now. I have difficulties to say anything specific about that file as we have different source files (particularly the "files" list of GDB source files). Therefore I packaged it all as: http://people.redhat.com/jkratoch/splint.tar.xz Particularly I tried to convince splint to process also these two files: interps.c.out:*** Segmentation Violation symtab.c.out:*** Segmentation Violation But there isn't anything LONGEST-interesting there anyway. But I find my "files" files is slightly more rich with several files needing an update (such as linux-record.c from a brief check). Thanks, Jan