From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17221 invoked by alias); 19 Jun 2012 10:49:01 -0000 Received: (qmail 17212 invoked by uid 22791); 19 Jun 2012 10:49:00 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Jun 2012 10:48:47 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5JAmlS0018813 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Jun 2012 06:48:47 -0400 Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5JAmhd0026812 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 19 Jun 2012 06:48:46 -0400 Date: Tue, 19 Jun 2012 10:49:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Regression for -gstabs+ [Re: FYI: fix spelling of "delete" in c-exp.y] Message-ID: <20120619104843.GA22015@host2.jankratochvil.net> References: <87k3z4pdzg.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k3z4pdzg.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00610.txt.bz2 Hi, On Mon, 18 Jun 2012 22:22:11 +0200, Tom Tromey wrote: > I'm checking this in. this exactly reverts my change: [WIP patch] Fix crash regressions after libiberty/ update http://sourceware.org/ml/gdb-patches/2012-01/msg00261.html I made there this change to match libiberty/cp-demangle.c cplus_demangle_operators[]. > Running the test suite with a modified compiler (jason/comdat-debug in > gcc git) shows a few regressions. I do not say which version is right but there should be some more settlement on why it is done. > Debugging one of these showed that there were some extra spaces in > c-exp.y, that caused problems in this test case. This patch removes the > spaces. "Extra" why? There seem to be missing spaces vs. the demanger now. It has caused regression for -gstabs+ (tested only on Fedora Rawhide): -PASS: gdb.cp/cplusfuncs.exp: print &foo::operator delete(void*) -PASS: gdb.cp/cplusfuncs.exp: print &foo::operator delete(void*) +FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator delete(void*) +FAIL: gdb.cp/cplusfuncs.exp: print &foo::operator delete(void*) I do not say -gstabs+ is required but it may suggest something is wrong. 69a179f1518fae5168238f8775ff46013d0d155e is the first bad commit commit 69a179f1518fae5168238f8775ff46013d0d155e Author: Tom Tromey Date: Mon Jun 18 20:23:30 2012 +0000 * c-exp.y (operator): Remove trailing space after "delete" and "delete[]". Maybe the right fix is elsewhere in GDB? Thanks, Jan