From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-92212-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15658 invoked by alias); 16 Jun 2012 15:16:21 -0000
Received: (qmail 15650 invoked by uid 22791); 16 Jun 2012 15:16:21 -0000
X-SWARE-Spam-Status: No, hits=-2.9 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 16 Jun 2012 15:16:09 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id q5GFG6lS008044;	Sat, 16 Jun 2012 17:16:06 +0200 (CEST)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id q5GFG4aE031058;	Sat, 16 Jun 2012 17:16:04 +0200 (CEST)
Date: Sat, 16 Jun 2012 15:16:00 -0000
Message-Id: <201206161516.q5GFG4aE031058@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: hjl.tools@gmail.com
CC: gdb-patches@sourceware.org
In-reply-to:	<CAMe9rOru5PNheb1FG=pSfQbdhtTTQmVB3Yip-vO-ZDL88E_dUA@mail.gmail.com>	(hjl.tools@gmail.com)
Subject: Re: [PATCH 5/5] Add x32 support to amd64_analyze_stack_align
References: <20120613230825.GA11653@intel.com>	<201206161127.q5GBRASA028790@glazunov.sibelius.xs4all.nl> <CAMe9rOru5PNheb1FG=pSfQbdhtTTQmVB3Yip-vO-ZDL88E_dUA@mail.gmail.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-06/txt/msg00545.txt.bz2

> Date: Sat, 16 Jun 2012 07:41:47 -0700
> From: "H.J. Lu" <hjl.tools@gmail.com>
> 
> On Sat, Jun 16, 2012 at 4:27 AM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> >> Date: Wed, 13 Jun 2012 16:08:25 -0700
> >> From: "H.J. Lu" <hongjiu.lu@intel.com>
> >>
> >> Hi,
> >>
> >> This patch adds support to amd64_analyze_stack_align.  OK to install?
> >
> > Sorry, no.  I think this function is complex enough as it is now.
> > Please create a seperate function for x32.  That may lead to some code
> > duplication, but that is better than increasing the complexity of this
> > already complex function.
> >
> 
> This patch adds amd64_x32_analyze_stack_align and uses it
> for x32.  OK to install?

Thanks, yes, this is fine.

> -- 
> H.J.
> ---
> 	* amd64-tdep.c (amd64_x32_analyze_stack_align): New function.
> 	(amd64_analyze_prologue): Call amd64_x32_analyze_stack_align
> 	for x32.