From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2648 invoked by alias); 16 Jun 2012 04:56:04 -0000 Received: (qmail 2638 invoked by uid 22791); 16 Jun 2012 04:56:03 -0000 X-SWARE-Spam-Status: No, hits=-8.5 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 16 Jun 2012 04:55:49 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 000521B4018; Sat, 16 Jun 2012 04:55:47 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: build error for mn10300-elf sim with your recent commit Date: Sat, 16 Jun 2012 04:56:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.4.0; KDE/4.6.5; x86_64; ; ) Cc: Pedro Alves , Joel Brobecker , "Hans-Peter Nilsson" References: <201206151846.q5FIkL3Z026410@ignucius.se.axis.com> <20120615195238.GB18729@adacore.com> <4FDBA5BC.8030300@redhat.com> In-Reply-To: <4FDBA5BC.8030300@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1513925.uoImMbjnXa"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201206160055.51737.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00535.txt.bz2 --nextPart1513925.uoImMbjnXa Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1713 On Friday 15 June 2012 17:14:36 Pedro Alves wrote: > $ cd sim > $ find . -name "*.[hc]" | xargs grep sysdep.h > ./d10v/interp.c:#include "sysdep.h" > ./cr16/interp.c:#include "sysdep.h" > ./moxie/interp.c:#include "sysdep.h" > ./mcore/interp.c:#include "sysdep.h" > ./sh64/sh-desc.c:#include "sysdep.h" > ./mn10300/interp.c:#include "sysdep.h" > ./microblaze/interp.c:#include "sysdep.h" > ./cris/traps.c:/* From ld/sysdep.h. */ > ./cris/cris-desc.c:#include "sysdep.h" >=20 > One's a comment. And, >=20 > $ find . -name sysdep.h > ./moxie/sysdep.h > ./mcore/sysdep.h > ./microblaze/sysdep.h >=20 > So that leaves: >=20 > ./d10v/interp.c:#include "sysdep.h" > ./cr16/interp.c:#include "sysdep.h" > ./sh64/sh-desc.c:#include "sysdep.h" > ./mn10300/interp.c:#include "sysdep.h" > ./cris/cris-desc.c:#include "sysdep.h" >=20 > I don't see these ports really caring for hosts other than > GNU/Linux and Windows. >=20 > It is wrong to include bfd/sysdeps.h, practically as much as it > is wrong to include bfd/config.h. bfd/sysdeps.h HAVE_FOOs depend on > bfd's own autoconfigury, not the sim's. >=20 > Consolidating all the commonality between all these sysdep.h files > sound nice, though I'm not sure how much work that is. i'd wager that it's more of a copy & paste error between seems. one of the= =20 really old ones had an interp.c that included sysdep.h, and when someone=20 started a new port, they copied an existing one. the local sysdep.h wasn't= =20 needed, but the build still worked, so no one looked further. the sim code= =20 base isn't exactly a shining glory of how things should be done :). i vote for deleting all sysdep.h inclusions where the port doesn't have a=20 local sysdep.h. -mike --nextPart1513925.uoImMbjnXa Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJP3BHXAAoJEEFjO5/oN/WBBW8QAIt+tSPcT2frbrzWIIMnThRJ BbjnRxBCH7txjGt64H48TZdv8cXrxWiCV3vjnbZ7v/5SHBWGULnJLqpqoUynGsdi 7G04NleSHtIgVo8i3eMUk5hUIf5aoclITHiYMPVQuApApX+eHnwPDKsIsRnFGXgd NBcIfwMcAOUqf7ircMz7wDXtiMvHtgMylmkMu2Xrn+JWNLaZTd8RkM6fWYBEKlvw rWplPnzqaBZ3S+ovPeU2byjLTWxOBGpQk428xN5uMFEDmHmjTsiE2bd/yOGOSkDb Mz8p2/+N9hJznWWwrNmyDNrm+g5mjS6blTGuzXXM/DA3ywfx1tnaO978LWOU7KW3 h+7yyTezOBOSg6CULomVKmNkTTNQz6hP7ZGfn+Yp2N2L2vaa6wyI8rJ60OwDqoCY D2pcNYlP6K4PO7FChREMF+xkAPdzrHlk7TUtwbTnUpFDqe4+yycRCDAtPzLMCGfv Jt+6adH/YBv6+eyqL6A0EiQKYsnppZ4UwKn30eQoLSytNCwzkBWkx+c9o4cc4SEr 7hrRMM3xI0/s6yzjgW3/FUt8bezqyqVzSnP1QgWZI5nQgwCD0ddOb6UPVX0R4xJr jyhWDtQzLR48LAsNUiVV0B6Xf68i1Bp7rjq9OvcUc5xW7V/HJzhq85HOeqOvdVZK ToqWxjw4fBMBtqQ2AGln =bj1Q -----END PGP SIGNATURE----- --nextPart1513925.uoImMbjnXa--