From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, Mark Kettenis <kettenis@gnu.org>
Subject: [patchv2] [mingw] Fix "%lld" compilation error
Date: Fri, 15 Jun 2012 16:49:00 -0000 [thread overview]
Message-ID: <20120615164852.GA2010@host2.jankratochvil.net> (raw)
In-Reply-To: <20120615155716.GQ18729@adacore.com>
On Fri, 15 Jun 2012 17:57:16 +0200, Joel Brobecker wrote:
> > 2012-06-15 Jan Kratochvil <jan.kratochvil@redhat.com>
> >
> > * common/buffer.c: Include inttypes.h.
> > (buffer_xml_printf): Use PRIdMAX, PRIuMAX, PRIxMAX and PRIoMAX.
>
> I vaguely remember us not necessarily wanting to use some of those,
> but I don't remember the details. Perhaps Mark remembers? It seems
> that gnulib might be dealing with portability issues for us...
Update, the previous patch broke x86_64 GNU/Linux build.
Thanks,
Jan
gdb/
2012-06-15 Jan Kratochvil <jan.kratochvil@redhat.com>
* common/buffer.c: Include inttypes.h and stdint.h.
(buffer_xml_printf): Use PRId64, PRIu64, PRIx64 and PRIo64.
--- a/gdb/common/buffer.c
+++ b/gdb/common/buffer.c
@@ -25,10 +25,12 @@
#include "xml-utils.h"
#include "buffer.h"
+#include "inttypes.h"
#include <stdlib.h>
#include <string.h>
#include <stdio.h>
+#include <stdint.h>
void
buffer_grow (struct buffer *buffer, const char *data, size_t size)
@@ -139,16 +141,20 @@ buffer_xml_printf (struct buffer *buffer, const char *format, ...)
switch (*f)
{
case 'd':
- sprintf (str, "%lld", va_arg (ap, long long));
+ sprintf (str, "%" PRId64,
+ (int64_t) va_arg (ap, long long));
break;
case 'u':
- sprintf (str, "%llu", va_arg (ap, unsigned long long));
+ sprintf (str, "%" PRIu64,
+ (uint64_t) va_arg (ap, unsigned long long));
break;
case 'x':
- sprintf (str, "%llx", va_arg (ap, unsigned long long));
+ sprintf (str, "%" PRIx64,
+ (uint64_t) va_arg (ap, unsigned long long));
break;
case 'o':
- sprintf (str, "%llo", va_arg (ap, unsigned long long));
+ sprintf (str, "%" PRIo64,
+ (uint64_t) va_arg (ap, unsigned long long));
break;
default:
str = 0;
next prev parent reply other threads:[~2012-06-15 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 15:44 [patch] " Jan Kratochvil
2012-06-15 15:57 ` Joel Brobecker
2012-06-15 16:49 ` Jan Kratochvil [this message]
2012-06-28 17:09 ` [commit] [patchv2] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120615164852.GA2010@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kettenis@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox