From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19954 invoked by alias); 15 Jun 2012 15:44:34 -0000 Received: (qmail 19895 invoked by uid 22791); 15 Jun 2012 15:44:32 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Jun 2012 15:44:12 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5FFiCmN015983 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 15 Jun 2012 11:44:12 -0400 Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5FFi8qe031085 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Fri, 15 Jun 2012 11:44:11 -0400 Date: Fri, 15 Jun 2012 15:44:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [patch] [mingw] Fix "%lld" compilation error Message-ID: <20120615154407.GA30377@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00509.txt.bz2 Hi, gdb-7.4.50.20120615/build_win32/gdb/gdbserver$ i686-w64-mingw32-gcc -c -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions --param=ssp-buffer-size=4 -D__USE_MINGW_ACCESS -I. -I../../../gdb/gdbserver -I../../../gdb/gdbserver/../common -I../../../gdb/gdbserver/../regformats -I../../../gdb/gdbserver/../../include -I../../../gdb/gdbserver/../gnulib/import -Ibuild-gnulib-gdbserver/import -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-char-subscripts -Werror ../../../gdb/gdbserver/../common/buffer.c -DGDBSERVER ../../../gdb/gdbserver/../common/buffer.c: In function 'buffer_xml_printf': ../../../gdb/gdbserver/../common/buffer.c:142:9: error: unknown conversion type character 'l' in format [-Werror=format] ../../../gdb/gdbserver/../common/buffer.c:142:9: error: too many arguments for format [-Werror=format-extra-args] ../../../gdb/gdbserver/../common/buffer.c:145:9: error: unknown conversion type character 'l' in format [-Werror=format] ../../../gdb/gdbserver/../common/buffer.c:145:9: error: too many arguments for format [-Werror=format-extra-args] ../../../gdb/gdbserver/../common/buffer.c:148:9: error: unknown conversion type character 'l' in format [-Werror=format] ../../../gdb/gdbserver/../common/buffer.c:148:9: error: too many arguments for format [-Werror=format-extra-args] ../../../gdb/gdbserver/../common/buffer.c:151:9: error: unknown conversion type character 'l' in format [-Werror=format] ../../../gdb/gdbserver/../common/buffer.c:151:9: error: too many arguments for format [-Werror=format-extra-args] cc1: all warnings being treated as errors According to: http://comments.gmane.org/gmane.comp.gnu.mingw.w64.general/4670 Kai Tietz: the issue is that formatter-width specifier %ll isn't supported for all msvcrt-DLL versions JonY: Use %I64u on Windows, or just use inttypes.h PRIuMAX. OK to check it in? Thanks, Jan gdb/ 2012-06-15 Jan Kratochvil * common/buffer.c: Include inttypes.h. (buffer_xml_printf): Use PRIdMAX, PRIuMAX, PRIxMAX and PRIoMAX. --- ./gdb/common/buffer.c-orig 2012-05-22 17:55:30.000000000 +0200 +++ ./gdb/common/buffer.c 2012-06-15 17:38:21.255770838 +0200 @@ -25,6 +25,7 @@ #include "xml-utils.h" #include "buffer.h" +#include "inttypes.h" #include #include @@ -139,16 +140,16 @@ buffer_xml_printf (struct buffer *buffer switch (*f) { case 'd': - sprintf (str, "%lld", va_arg (ap, long long)); + sprintf (str, "%" PRIdMAX, va_arg (ap, long long)); break; case 'u': - sprintf (str, "%llu", va_arg (ap, unsigned long long)); + sprintf (str, "%" PRIuMAX, va_arg (ap, unsigned long long)); break; case 'x': - sprintf (str, "%llx", va_arg (ap, unsigned long long)); + sprintf (str, "%" PRIxMAX, va_arg (ap, unsigned long long)); break; case 'o': - sprintf (str, "%llo", va_arg (ap, unsigned long long)); + sprintf (str, "%" PRIoMAX, va_arg (ap, unsigned long long)); break; default: str = 0;