From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24122 invoked by alias); 14 Jun 2012 15:01:55 -0000 Received: (qmail 24108 invoked by uid 22791); 14 Jun 2012 15:01:52 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Jun 2012 15:01:39 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SfBYI-0005J7-6f from Yao_Qi@mentor.com ; Thu, 14 Jun 2012 08:01:38 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 14 Jun 2012 08:01:02 -0700 Received: from yaolp.localnet (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Thu, 14 Jun 2012 08:01:36 -0700 From: Yao Qi To: Pedro Alves Subject: Re: [PATCH 4/4] gdb: kfail for PR14161 Date: Thu, 14 Jun 2012 15:01:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.32-41-generic; KDE/4.4.5; i686; ; ) CC: References: <1339246002-1987-1-git-send-email-yao@codesourcery.com> <1339246002-1987-5-git-send-email-yao@codesourcery.com> <4FD76C4E.20107@redhat.com> In-Reply-To: <4FD76C4E.20107@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <201206142301.34598.yao@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00470.txt.bz2 On Wednesday 13 June 2012 00:20:30 Pedro Alves wrote: > > + # Due to PR gdb/14161, sockets files are not removed when agent > > exists. > > > > + # However this problem only affects native gdb, so we don't have to > > bother > > > > + # 'remote_file target delete'. Simple tcl command 'file delete' > > should + # be OK. > > + eval file delete [glob "/tmp/gdb_ust*"] > > + > > "bother with". But note this doesn't work with remote host testing. I use "remote_file target delete" in the new patch when "is_remote target" is true, otherwise use tcl builtin command to remove files. gdb/testsuite: 2012-06-14 Yao Qi KFAIL for PR14161. * gdb.trace/strace.exp (strace_remove_socket): kfail for native. Cleanup socket files. --- gdb/testsuite/gdb.trace/strace.exp | 14 +++++++++++++- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/gdb/testsuite/gdb.trace/strace.exp b/gdb/testsuite/gdb.trace/strace.exp index b96ab41..1520055 100644 --- a/gdb/testsuite/gdb.trace/strace.exp +++ b/gdb/testsuite/gdb.trace/strace.exp @@ -100,6 +100,10 @@ proc strace_remove_socket { action } { sleep 5 + if { ![is_remote target] && ! [string equal $action "detach"] } { + setup_kfail gdb/14161 *-*-* + } + set test "socket file removed" if [is_remote target] { set status [remote_exec target "sh -c \"exit `\\\[ -S $socket_file ]`\""] @@ -332,7 +336,15 @@ if { ![is_remote target] strace_remove_socket "quit" strace_remove_socket "detach" strace_remove_socket "continue" + + # Due to PR gdb/14161, sockets files are not removed when agent exists. + if [is_remote target] { + foreach match [glob -nocomplain "/tmp/gdb_ust*"] { + remote_file target delete $match + } + } else { + eval file delete [glob "/tmp/gdb_ust*"] + } return } if { ![gdb_target_supports_trace] } then { -- 1.7.0.4