From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5744 invoked by alias); 13 Jun 2012 18:19:15 -0000 Received: (qmail 5734 invoked by uid 22791); 13 Jun 2012 18:19:14 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jun 2012 18:18:54 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5DIIfvn015993 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Jun 2012 14:18:41 -0400 Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5DIIbER017096 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 13 Jun 2012 14:18:40 -0400 Date: Wed, 13 Jun 2012 18:19:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: Mark Kettenis , gdb-patches@sourceware.org Subject: [commit] [patchv2] Fix Sun compiler compat. for empty structs (PR build/14003) Message-ID: <20120613181836.GA3517@host2.jankratochvil.net> References: <20120612204751.GA13700@host2.jankratochvil.net> <20120612212413.GS2687@adacore.com> <20120612215116.GA23941@host2.jankratochvil.net> <20120613065059.GA11317@host2.jankratochvil.net> <201206130830.q5D8UBv8028230@glazunov.sibelius.xs4all.nl> <20120613084834.GA20233@host2.jankratochvil.net> <20120613144716.GA18729@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120613144716.GA18729@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00430.txt.bz2 Hi Joel, On Wed, 13 Jun 2012 16:47:16 +0200, Joel Brobecker wrote: > > I believe in a rule runtime on GNU system should not be negatively affected by > > non-GNU systems defects compatibility. > > But I don't understand why you would say that, since it's not a GNU vs > non-GNU. It's a correctness issue. We're just lucky that GCC accepts it. Because if GNU components use only the lowest common denominator of all the other OSes, they can barely ever catch up those. > How many instances of this struct are we talking about? That's about principles. > > I can do so if anybody does not like the #if 0 construct. > > Just repeating what I said before: I am OK with that, I have tried today to install Solaris 11 but I failed to install Solaris Studio (the compiler) into it, it wants include files not present anywhere. I wanted to (write and) test the autoconf variant there. Therefore checked in the #if 0 variant: http://sourceware.org/ml/gdb-cvs/2012-06/msg00098.html Thanks, Jan