From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32356 invoked by alias); 13 Jun 2012 15:01:08 -0000 Received: (qmail 32346 invoked by uid 22791); 13 Jun 2012 15:01:07 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO,TW_GJ,TW_TJ X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jun 2012 15:00:47 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3832E1C6E12; Wed, 13 Jun 2012 11:00:47 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id IrBffen5bnw1; Wed, 13 Jun 2012 11:00:47 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 02DE51C6DAE; Wed, 13 Jun 2012 11:00:46 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3875E145616; Wed, 13 Jun 2012 08:00:44 -0700 (PDT) Date: Wed, 13 Jun 2012 15:01:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: Mark Kettenis , gdb-patches@sourceware.org Subject: Re: ping: [patch 1/2] Fix gdb.cp/gdb2495.exp regression with gcc-4.7 #5 Message-ID: <20120613150044.GF18729@adacore.com> References: <20120309210045.GA30432@host2.jankratochvil.net> <20120326190355.GA11001@host2.jankratochvil.net> <201203261953.q2QJrXX4023325@glazunov.sibelius.xs4all.nl> <20120326203151.GA18085@host2.jankratochvil.net> <201203262145.q2QLjRIJ024024@glazunov.sibelius.xs4all.nl> <20120327081439.GA8387@host2.jankratochvil.net> <20120611152148.GA31854@adacore.com> <20120611160830.GA10865@host2.jankratochvil.net> <20120611192459.GM2687@adacore.com> <20120611194037.GA32003@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120611194037.GA32003@host2.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00410.txt.bz2 I took some time to sleep on this... > > 1. Ignore the initial regression, and release with it > > This is not good, this regresses a nice C++ fixup by Tom. > > > > 2. Revert the patch that caused the regression. I can't remember > > which patch that was, and whether it would "unsolve" an important > > issue. > > The regression is due to binutils fix by Jakub Jelinek: > http://sourceware.org/bugzilla/show_bug.cgi?id=12570 > > There is nothing to revert. The original assumption _start has no unwind info > was just wrong. Moreover there was a bug that it relied upon the fact that > .plt has no unwind info. But after fixing it to make it really _start (and > not .plt) some archs (ppc IIRC) has unwind info even for _start. OK and OK. Thanks for the feedback on these points. > > 3. Ignore the side-effect/regression caused by this fix, and fix > > it later > > Yes, I find it a viable alternative. > > > > 4. Delay the release in order to implement setjmp handling. > > I already tried to implement it once but somehow did not finish it. I do no > like much that even the longjmps tracking is not a perfect solution. It seems to me that fixing the problem is going to be quite delicate, since you keep finding regressions with all the solutions you've been considering. So I am inclined to accept the regression for 7.5 too. -- Joel