From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-92073-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23993 invoked by alias); 13 Jun 2012 14:50:09 -0000
Received: (qmail 23980 invoked by uid 22791); 13 Jun 2012 14:50:06 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jun 2012 14:49:44 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id 2C3121C67F3;	Wed, 13 Jun 2012 10:49:44 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id LKvhGuoBHFKK; Wed, 13 Jun 2012 10:49:44 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id E3FCB1C6701;	Wed, 13 Jun 2012 10:49:43 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000)	id 30DF1145616; Wed, 13 Jun 2012 07:49:42 -0700 (PDT)
Date: Wed, 13 Jun 2012 14:50:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,	Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH 04/10] Ada language.
Message-ID: <20120613144942.GB18729@adacore.com>
References: <1338665528-5932-1-git-send-email-sergiodj@redhat.com> <1338665528-5932-5-git-send-email-sergiodj@redhat.com> <m3haufu7wa.fsf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3haufu7wa.fsf@redhat.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-06/txt/msg00406.txt.bz2

Hi Sergio,

> Ping.

Sorry, Sergio. I really thought I had reviewed this change and sent
my OK.

> >  gdb/ada-exp.y  |  474 +++++++++++++++++++++++++++++---------------------------
> >  gdb/ada-lang.c |    4 +-
> >  gdb/ada-lang.h |    3 +-
> >  gdb/ada-lex.l  |   54 ++++---
> >  4 files changed, 282 insertions(+), 253 deletions(-)

I skimmed through the changes again, and they still looked OK to me.
I really like changes like this one where globals are being removed.
Thanks!

-- 
Joel