From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25079 invoked by alias); 13 Jun 2012 00:46:02 -0000 Received: (qmail 25066 invoked by uid 22791); 13 Jun 2012 00:46:02 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,SPF_NEUTRAL X-Spam-Check-By: sourceware.org Received: from ozlabs.org (HELO ozlabs.org) (203.10.76.45) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jun 2012 00:45:50 +0000 Received: from kryten (ppp121-45-170-72.lns20.syd6.internode.on.net [121.45.170.72]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPSA id 72A3CB6FCB; Wed, 13 Jun 2012 10:45:48 +1000 (EST) Date: Wed, 13 Jun 2012 00:46:00 -0000 From: Anton Blanchard To: Edjunior Barbosa Machado Cc: "Gustavo, Luis" , Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Fix ppc64 single step over atomic sequence testcase Message-ID: <20120613104548.416ba64f@kryten> In-Reply-To: <4FD773F3.1090307@linux.vnet.ibm.com> References: <20120606135557.7da37cbe@kryten> <20120611193326.GN2687@adacore.com> <20120612224515.15bc044d@kryten> <4FD73EB2.3070705@mentor.com> <20120612131650.GP2687@adacore.com> <4FD743FA.4010403@mentor.com> <4FD773F3.1090307@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00374.txt.bz2 Hi Edjunior, > I had the chance to test the patch and rewriting this in assembly > does fixes the tests regardless of gcc version. However, the only > "issue" I noticed was that it should be run inside the src directory, > otherwise it will fail due to the asm .include's: > > spawn -ignore SIGHUP > gcc ../../../gdb.git/gdb/testsuite/gdb.arch/ppc64-atomic-inst.s -g > -lm > -o /home/emachado/gdb/build/gdb/testsuite/gdb.arch/ppc64-atomic-inst^M ../../../gdb.git/gdb/testsuite/gdb.arch/ppc64-atomic-inst.s: > Assembler > messages:^M ../../../gdb.git/gdb/testsuite/gdb.arch/ppc64-atomic-inst.s:1: > Error: can't open gdb.asm/common.inc for reading: No such file or > directory^M ../../../gdb.git/gdb/testsuite/gdb.arch/ppc64-atomic-inst.s:2: > Error: can't open gdb.asm/powerpc64.inc for reading: No such file or > directory^M ../../../gdb.git/gdb/testsuite/gdb.arch/ppc64-atomic-inst.s:5: > Error: Unrecognized opcode: `gdbasm_declare'^M Thanks for testing. It looks like no one else is using the asm macros outside of gdb.asm. Any suggestions? I'm only using one macro so I could open code it I guess. Anton