Re: [patchv2] Fix Sun compiler compat. for empty structs (PR build/14003)

Joel Brobecker
2012-06-13T14:47:49Z

> I believe in a rule runtime on GNU system should not be negatively affected by
> non-GNU systems defects compatibility.

But I don't understand why you would say that, since it's not a GNU vs
non-GNU. It's a correctness issue. We're just lucky that GCC accepts it.

How many instances of this struct are we talking about? Just a few,
right? So it's just a few wasted bytes... That's now 3 people who
suggested it, I think it's a good compromise.

> I can do so if anybody does not like the #if 0 construct.

Just repeating what I said before: I am OK with that, just not my
prefered solution. At the risk of looking like a despot, I would
not spend too much time arguing about this. This is one of these
issues that is just too minor to be wasting emails and time. Unless
there are real objections, you are the one working on the change,
so go with that you prefer.

--
Joel