From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10907 invoked by alias); 12 Jun 2012 09:56:04 -0000 Received: (qmail 10899 invoked by uid 22791); 12 Jun 2012 09:56:03 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Jun 2012 09:55:48 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5C9tmRp016694 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 12 Jun 2012 05:55:48 -0400 Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5C9tiWW026189 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 12 Jun 2012 05:55:47 -0400 Date: Tue, 12 Jun 2012 09:56:00 -0000 From: Jan Kratochvil To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH v3] Expand bitpos and type.length to LONGEST and ULONGEST Message-ID: <20120612095543.GA10148@host2.jankratochvil.net> References: <20120524150105.GA8232@host2.jankratochvil.net> <20120531234422.3ea35cde@spoyarek> <20120605222651.GA25480@host2.jankratochvil.net> <20120606235335.7fa94030@spoyarek> <20120606213420.GA9219@host2.jankratochvil.net> <20120608141636.GA24175@host2.jankratochvil.net> <20120608152735.GA26491@host2.jankratochvil.net> <20120611182346.1b8d872b@spoyarek> <20120611125933.GA7733@host2.jankratochvil.net> <20120612000336.5dfcc246@spoyarek> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120612000336.5dfcc246@spoyarek> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00327.txt.bz2 On Mon, 11 Jun 2012 20:33:36 +0200, Siddhesh Poyarekar wrote: > rm -rf splint/ > mkdir -p splint/bits > touch splint/bits/confname.h > for i in `cat files`; do > mkdir -p splint/`dirname $i` > splint +posixlib +gnuextensions -linelen 999 -hints -showcolumn > \ -Isplint -exportlocal -DTUI -I. \ > -Icommon -I../include -I../bfd -I../libdecnumber > -I../opcodes \ -I.. -I/usr/include/python2.7 $i &>splint/$i.out > done BTW this line wrapping corrupted the script, it is not convenient to copy-past it then. > After running this script the changes to review have come to approx > 2500 lines (also attached). Does this look OK? If it does, then I can do > a step-by-step review of these changes and post them. Yes, I agree with everything you did. Just I have now found splint crashes on some files so the results are incomplete and some regressions may have been missed. I have filed https://bugzilla.redhat.com/show_bug.cgi?id=831141 But apparently maybe just removing some assertion would be enough for this GDB purpose. Thanks, Jan