From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15123 invoked by alias); 11 Jun 2012 12:53:51 -0000 Received: (qmail 15113 invoked by uid 22791); 11 Jun 2012 12:53:50 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,MAY_BE_FORGED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jun 2012 12:53:30 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5BCrUj7000429 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 11 Jun 2012 08:53:30 -0400 Received: from spoyarek (dhcp223-8.pnq.redhat.com [10.65.223.8] (may be forged)) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5BCrN5v018022; Mon, 11 Jun 2012 08:53:25 -0400 Date: Mon, 11 Jun 2012 12:53:00 -0000 From: Siddhesh Poyarekar To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH v3] Expand bitpos and type.length to LONGEST and ULONGEST Message-ID: <20120611182346.1b8d872b@spoyarek> In-Reply-To: <20120608152735.GA26491@host2.jankratochvil.net> References: <20120515200454.GA11338@host2.jankratochvil.net> <20120523192245.0f785e69@spoyarek> <20120523174610.GA23405@host2.jankratochvil.net> <20120524070634.4e346d9d@spoyarek> <20120524150105.GA8232@host2.jankratochvil.net> <20120531234422.3ea35cde@spoyarek> <20120605222651.GA25480@host2.jankratochvil.net> <20120606235335.7fa94030@spoyarek> <20120606213420.GA9219@host2.jankratochvil.net> <20120608141636.GA24175@host2.jankratochvil.net> <20120608152735.GA26491@host2.jankratochvil.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00278.txt.bz2 On Fri, 8 Jun 2012 17:27:35 +0200, Jan wrote: > On Fri, 08 Jun 2012 16:16:36 +0200, Jan Kratochvil wrote: > > Wrote the attached script and the "diff" has now "just" 7375 > > lines. This seems to be reviewable. > > Fixed there some whitespacing issues, therefore: > > rm -rf splint/;mkdir -p splint/bits;touch splint/bits/confname.h;for > i in `cat files`;do mkdir -p splint/`dirname $i`;splint +posixlib > +gnuextensions -Isplint -exportlocal -DTUI -I. -Icommon -I../include > -I../bfd -I../libdecnumber -I../opcodes -I.. -I/usr/include/python2.7 > $i &>splint/$i.out;done appropriately mv splint splint-clean and mv > splint splint-bitpos find splint-clean/ -type f|sort|xargs cat|perl > -lpe 's/^(\s*)(\S*?\.[ch]:\d+:\d+):/$1LOC $2\n/' >splint-clean.out > find splint-bitpos/ -type f|sort|xargs cat|perl -lpe > 's/^(\s*)(\S*?\.[ch]:\d+:\d+):/$1LOC $2\n/' >splint-bitpos.out > locdiff splint-clean.out splint-bitpos.out > > http://people.redhat.com/jkratoch/locdiff.out > Thanks, I'm building on your idea to make the list even smaller. So far, adding '-hints -showcolumn -linelen 999' to the splint commandline and then adjusting the above regex to remove the additional \d+: has forced all outputs to be cleaner and in one-line per warning, so we can expect output of the type: LOC - - in a lot of cases. This has reduced the output to about 4.2k, mostly due to the reduced wrapping. I am now working on using this to eliminate the following warnings: * Warnings about the argument 2 of extract_unsigned_integer having to be int. This is the size of a primitive and is hence always safe. * Earlier warning was assignment from int to unsigned int (or vice-versa) and that has now changed from LONGEST to ULONGEST. These form a fairly large part of the outputs, so I hope to make the final list to review much smaller than what we currently have. Please let me know if any of the above assumptions or wrong or if there are any other cases I can eliminate. Thanks, Siddhesh