From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-91946-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19605 invoked by alias); 11 Jun 2012 13:00:03 -0000
Received: (qmail 19571 invoked by uid 22791); 11 Jun 2012 13:00:02 -0000
X-SWARE-Spam-Status: No, hits=-6.3 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jun 2012 12:59:50 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5BCxnTr001786	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 11 Jun 2012 08:59:49 -0400
Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5BCxZbG022092	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 11 Jun 2012 08:59:43 -0400
Date: Mon, 11 Jun 2012 13:00:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Siddhesh Poyarekar <siddhesh@redhat.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH v3] Expand bitpos and type.length to LONGEST and ULONGEST
Message-ID: <20120611125933.GA7733@host2.jankratochvil.net>
References: <20120523174610.GA23405@host2.jankratochvil.net> <20120524070634.4e346d9d@spoyarek> <20120524150105.GA8232@host2.jankratochvil.net> <20120531234422.3ea35cde@spoyarek> <20120605222651.GA25480@host2.jankratochvil.net> <20120606235335.7fa94030@spoyarek> <20120606213420.GA9219@host2.jankratochvil.net> <20120608141636.GA24175@host2.jankratochvil.net> <20120608152735.GA26491@host2.jankratochvil.net> <20120611182346.1b8d872b@spoyarek>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120611182346.1b8d872b@spoyarek>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-06/txt/msg00279.txt.bz2

On Mon, 11 Jun 2012 14:53:46 +0200, Siddhesh Poyarekar wrote:
>  LOC <location>
> - <old>
> - <new>

nitpick: + at the <new> line.


> * Warnings about the argument 2 of extract_unsigned_integer having to
>   be int. This is the size of a primitive and is hence always safe.
> * Earlier warning was assignment from int to unsigned int (or
>   vice-versa) and that has now changed from LONGEST to ULONGEST.
[...]
> Please let me know if any of the above assumptions or wrong or if there are
> any other cases I can eliminate.

I agree with these assumptions.


Thanks,
Jan