From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8213 invoked by alias); 8 Jun 2012 14:16:59 -0000 Received: (qmail 8204 invoked by uid 22791); 8 Jun 2012 14:16:57 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Jun 2012 14:16:42 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q58EGfu7018905 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 8 Jun 2012 10:16:41 -0400 Received: from host2.jankratochvil.net (ovpn-116-47.ams2.redhat.com [10.36.116.47]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q58EGbp9018236 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 8 Jun 2012 10:16:39 -0400 Date: Fri, 08 Jun 2012 14:16:00 -0000 From: Jan Kratochvil To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH v3] Expand bitpos and type.length to LONGEST and ULONGEST Message-ID: <20120608141636.GA24175@host2.jankratochvil.net> References: <20120504183858.67d416b7@spoyarek> <20120515200454.GA11338@host2.jankratochvil.net> <20120523192245.0f785e69@spoyarek> <20120523174610.GA23405@host2.jankratochvil.net> <20120524070634.4e346d9d@spoyarek> <20120524150105.GA8232@host2.jankratochvil.net> <20120531234422.3ea35cde@spoyarek> <20120605222651.GA25480@host2.jankratochvil.net> <20120606235335.7fa94030@spoyarek> <20120606213420.GA9219@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="sdtB3X0nJg68CQEu" Content-Disposition: inline In-Reply-To: <20120606213420.GA9219@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00231.txt.bz2 --sdtB3X0nJg68CQEu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 725 On Wed, 06 Jun 2012 23:34:20 +0200, Jan Kratochvil wrote: > Used: > rm -rf splint/;mkdir -p splint/bits;touch splint/bits/confname.h;for i in `cat files`;do mkdir -p splint/`dirname $i`;splint +posixlib +gnuextensions -Isplint -exportlocal -DTUI -I. -Icommon -I../include -I../bfd -I../libdecnumber -I../opcodes -I.. -I/usr/include/python2.7 $i &>splint/$i.out;done > find splint-bitpos/ -type f|sort|xargs cat|perl -lpe 's/^\s*(\S*?\.[ch]:\d+:\d+):/LOC $1\n/' >splint-bitpos.out > diff -I"^LOC " splint-clean.out splint-bitpos.out|vim - [...] > It has 26000 lines this way, I will try to reduce the diff size somehow. Wrote the attached script and the "diff" has now "just" 7375 lines. This seems to be reviewable. Jan --sdtB3X0nJg68CQEu Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=locdiff Content-length: 1009 #! /usr/bin/perl use strict; use warnings; @ARGV==2 or die; sub readfile($) { my($fname)=@_; local *F; open F,$fname or die $fname; my $F=do { local $/; ; }; defined $F or die $fname; close F or die $fname; return $F; } sub writefile($$) { my($fname,$content)=@_; local *F; open F,">$fname" or die $fname; print F $content or die $fname; close F or die $fname; } sub strip($$$) { my($dst,$src,$locref)=@_; my $f=readfile $src; $f=~s{^LOC (.*)$}{push @$locref,$1;"LOC";}egm; writefile $dst,$f; } my $t="/tmp/locdiff.$$"; my($a,$b)=("$t.a","$t.b"); my(@a,@b); strip $a,$ARGV[0],\@a; strip $b,$ARGV[1],\@b; my $f=readfile "diff -U-1 $a $b||true|"; die if 2!=unlink "$a","$b"; $f=~s{^([-+ ])LOC$}{ my $l; if ($1 eq "-") { $l=shift @a; } elsif ($1 eq "+") { $l=shift @b; } else { die if $1 ne " "; $l=shift @a; my $r=shift @b; $l="$r ($l)" if $l ne $r; } "$1LOC $l"; }egm; 1 while $f=~s{^ LOC .*\n(?: .*?\n)*?(.LOC )}{$1}gm; print $f; --sdtB3X0nJg68CQEu--