From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit 2/2] testsuite: code_elim.exp: Fix false FAIL
Date: Sun, 03 Jun 2012 17:37:00 -0000 [thread overview]
Message-ID: <20120603173734.GA24877@host2.jankratochvil.net> (raw)
In-Reply-To: <m2haustic4.fsf@igel.home>
On Sun, 03 Jun 2012 19:29:15 +0200, Andreas Schwab wrote:
> Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> > + (order2: add-symbol-file ${testfile1} 0x100000): Add -s .data and -s
> > + .bss as appropriate.
>
> What about .sdata or .sbss (or whatever other section the compiler
> chooses)?
As I stated I do not know how to easily do a real fix of this testcase so
I just made non-regressing improvement for the platforms I regression test.
IMO a real fix is to implement add-symbol-file to (also) accept full
displacement but this seems to be outside of the scope of this testfile/fixup
and I have too many open other work to get into another task.
If you state non-existing sections GDB will make a warning in such case.
(Sure the testcase can ignore such warning.)
Thanks,
Jan
next prev parent reply other threads:[~2012-06-03 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-03 17:17 Jan Kratochvil
2012-06-03 17:29 ` Andreas Schwab
2012-06-03 17:37 ` Jan Kratochvil [this message]
2012-06-04 2:16 ` Yao Qi
2012-07-19 7:40 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120603173734.GA24877@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox