From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10221 invoked by alias); 2 Jun 2012 15:32:33 -0000 Received: (qmail 10211 invoked by uid 22791); 2 Jun 2012 15:32:31 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO,TW_BJ X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 02 Jun 2012 15:32:10 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 88C221C67EE; Sat, 2 Jun 2012 11:32:09 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id jQpguk0ZZ3aG; Sat, 2 Jun 2012 11:32:09 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 569921C67BF; Sat, 2 Jun 2012 11:32:09 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 03BD8145616; Sat, 2 Jun 2012 08:32:07 -0700 (PDT) Date: Sat, 02 Jun 2012 15:32:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [RFA 3/3] Windows-specific iterate_over_objfiles_in_search_order Message-ID: <20120602153206.GA2659@adacore.com> References: <1338496603-5423-1-git-send-email-brobecker@adacore.com> <1338496603-5423-4-git-send-email-brobecker@adacore.com> <20120602135647.GA18163@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120602135647.GA18163@host2.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00052.txt.bz2 > amd64-windows-tdep.c: In function ?$B!Famd64_windows_init_abi?$B!G: > amd64-windows-tdep.c:178:15: error: ?$B!Fwindows_iterate_over_objfiles_in_search_order?$B!G undeclared (first use in this function) Sorry, I thought I had compiled this file, but apparently not. > But on Fedora 17 (all x86* archs) it regresses these new testcase, they should > apparently be also made target specific: > > -PASS: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from partial symtab > -PASS: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from symtab > +FAIL: gdb.base/ctxobj.exp: print libctxobj2's this_version_num from partial symtab Yes, they should. I actually thought I had reverted them, since they are not in my sandbox. Not sure what happened there, I will double- check. > I would also prefer to use there in all the definitions/declarations: > typedef int > (iterate_over_objfiles_in_search_order_cb_ftype) (struct objfile *objfile, > void *cb_data); So do I, except that it raised a question: Where should this typedef be located? It can't really be declared next to the only function that's going to use it, since this section of the code is generated on a loop from the data read in gdbarch.sh. The only real location I thought was acceptable would be at the start of gdbarch.h. It's easy to modify gdbarch.sh to add this typedef, but then we create a maintenance issue where, should we delete this gdbarch method, we will probably forget to delete the typedef. This is why I went with the solution I chose. I'm OK going the other way, but I'd rather be sure that this is what people want. -- Joel