Re: [1/2][PATCH v3] Expand bitpos and type.length to LONGEST and ULONGEST

Siddhesh Poyarekar
2012-06-20T16:32:57Z

On Wed, 20 Jun 2012 17:47:20 +0200, Jan wrote:
> On Mon, 18 Jun 2012 12:30:27 +0200, Siddhesh Poyarekar wrote:
> > * Remove blocks that do not record changes, i.e. of the type:
> >
> > --- 8< -----
> > LOC... |
> > foo... |=> Remove this.
> > bar... |
> > --- 8< -----
> > [ -+]LOC...
>
> BTW these are already removed by "locdiff" itself, why another pass?

There still were many such instances I found.

> > If these changes are OK, then I'll record my review on the resultant
> > locdiff.processed.out, which is 2330 lines now.
>
> I have difficulties to say anything specific about that file as we
> have different source files (particularly the "files" list of GDB
> source files).
>
> Therefore I packaged it all as:
> http://people.redhat.com/jkratoch/splint.tar.xz

Oh right, I took files as the list of files that got changed in the
patch since I simply assumed that that was what you were using -- I
should have asked.

> Particularly I tried to convince splint to process also these two
> files: interps.c.out:*** Segmentation Violation
> symtab.c.out:*** Segmentation Violation
> But there isn't anything LONGEST-interesting there anyway.
>
> But I find my "files" files is slightly more rich with several files
> needing an update (such as linux-record.c from a brief check).
>

I'll look through this again.

Thanks,
Siddhesh