Re: [RFA-v3] Add scripts to generate ARI web pages to gdb/contrib/ari directory

Joel Brobecker
2012-05-29T13:02:05Z

Hi Pierre,

> As explained in my answer to Sergio, I would like to leave other fixes
> to after initial commit to have a better history of changes relative
> to the ss directory version on sourceware.org server.

That would be fine. I think that's a good reason.

> PS: could contrib get a separate ChangeLog file?

I think we are trying to get as few ChangeLog files as possible.
Any reason why you'd like to have your own ChangeLog file? It does
not seem unreasonable since the changes in contrib/ari as probably
expected to be few and far between once it's stabilized, and
having them listed in the main ChangeLog might make it harder to
have a quick list of the changes made in that directory over time...

> 2012-05-28 Pierre Muller <muller@ics.u-strasbg.fr>
>
> * contrib/ari/create-web-ari-in-src.sh: New file.
> * contrib/ari/gdb_ari.sh: New file.
> * contrib/ari/gdb_find.sh: New file.
> * contrib/ari/update-web-ari.sh: New file.

> ? contrib/ari/patch
> Index: contrib/ari/create-web-ari-in-src.sh
> ===================================================================
> RCS file: contrib/ari/create-web-ari-in-src.sh
> diff -N contrib/ari/create-web-ari-in-src.sh
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ contrib/ari/create-web-ari-in-src.sh 28 May 2012 18:17:56 -0000
> @@ -0,0 +1,68 @@
> +#! /bin/sh
> +
> +# GDB script to create web ARI page directly from within gdb/ari directory.
^^^^^^^^^

gdb/contrib/ari ?

> +set -x

We'll probably want to remove that, at some point, and remove all
the associated "set +x" in the other scripts.

> +# update-web-ari.sh script wants four parameters
> +# 1: directory of checkout src or gdb-RELEASE for release sources.
> +# 2: a temp directory.
> +# 3: a directory for generated web page.
> +# 4: The name of the current package, must be gdb here.
> +# Here we provide default values for these 4 parameters

Are the parameters passed via the environment?

> +# Default location of generate index.hmtl web page.
> +if [ -z "${webdir}" ] ; then
> + webdir=~/htdocs/www/local/ari
> +fi

Default location should be current working directory, IMO.

> +# Launch update-web-ari.sh in same directory as current script.
> +${scriptpath}/update-web-ari.sh ${srcdir} ${tempdir} ${webdir} gdb

Same as "set -x", we'll probably want to get rid of the final parameter
eventually, since we know it'll always be "gdb" for us.

--
Joel