From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29238 invoked by alias); 28 May 2012 11:03:32 -0000 Received: (qmail 29219 invoked by uid 22791); 28 May 2012 11:03:32 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-pz0-f41.google.com (HELO mail-pz0-f41.google.com) (209.85.210.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 May 2012 11:03:19 +0000 Received: by dakp5 with SMTP id p5so4096021dak.0 for ; Mon, 28 May 2012 04:03:19 -0700 (PDT) Received: by 10.68.131.35 with SMTP id oj3mr25922071pbb.156.1338202998425; Mon, 28 May 2012 04:03:18 -0700 (PDT) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id z2sm18950568pbv.34.2012.05.28.04.03.15 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 28 May 2012 04:03:17 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 7371CEA1D79; Mon, 28 May 2012 20:33:13 +0930 (CST) Date: Mon, 28 May 2012 11:03:00 -0000 From: Alan Modra To: Siddhesh Poyarekar Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH] bfd: Use size_t for length argument totarget_read_memory function passed into bfd_elf_bfd_from_remote_memory Message-ID: <20120528110313.GH3086@bubble.grove.modra.org> Mail-Followup-To: Siddhesh Poyarekar , binutils@sourceware.org, gdb-patches@sourceware.org References: <20120528143520.29254d79@spoyarek> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120528143520.29254d79@spoyarek> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00989.txt.bz2 On Mon, May 28, 2012 at 02:35:20PM +0530, Siddhesh Poyarekar wrote: > 2012-05-28 Siddhesh Poyarekar > > * bfd-in.h (bfd_elf_bfd_from_remote_memory): Make LEN argument > of target_read_memory as size_t. > * bfd-in2.h: Regenerate. > * elf-bfd.h (elf_backend_bfd_from_remote_memory): Make LEN > argument of target_read_memory as size_t. > (_bfd_elf32_bfd_from_remote_memory): Likewise. > (_bfd_elf64_bfd_from_remote_memory): Likewise. > * elf.c (bfd_elf_bfd_from_remote_memory): Likewise. > * enfcode.h (NAME): Likewise. Since Jan has already given the OK, and these functions are only used by gdb, binutils maintainers hardly need to look at the patch. OK anyway, but please fix the ChangeLog * elfcode.h (NAME(_bfd_elf,bfd_from_remote_memory)): Likewise. -- Alan Modra Australia Development Lab, IBM