From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2723 invoked by alias); 24 May 2012 23:06:16 -0000 Received: (qmail 2711 invoked by uid 22791); 24 May 2012 23:06:14 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 May 2012 23:05:54 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4ON5Vo6023348 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 24 May 2012 19:05:32 -0400 Received: from host2.jankratochvil.net (ovpn-116-78.ams2.redhat.com [10.36.116.78]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4OMAmTq002875 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 24 May 2012 18:10:53 -0400 Date: Thu, 24 May 2012 23:06:00 -0000 From: Jan Kratochvil To: John Steele Scott Cc: Joel Brobecker , Tom Tromey , gdb-patches@sourceware.org Subject: [commit] [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries. (testcase) Message-ID: <20120524221048.GA516@host2.jankratochvil.net> References: <4EA3E995.8040206@toojays.net> <20111026221057.GA24628@host1.jankratochvil.net> <4EBFAC05.2070501@toojays.net> <4FA49314.5020508@toojays.net> <20120505151557.GU15555@adacore.com> <87wr4h4vvd.fsf@quantum.com> <20120512183741.GB20606@host2.jankratochvil.net> <87d35xpwp4.fsf@quantum.com> <87aa11pwic.fsf@quantum.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87aa11pwic.fsf@quantum.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00953.txt.bz2 On Mon, 21 May 2012 14:08:11 +0200, John Steele Scott wrote: > Add test for GDB PR 13277. > > 2011-11-21 John Steele Scott > > PR symtab/13277: Resolving opaque structures in ICC generated binaries. > * gdb.dwarf2/dw2-icc-opaque.S: New file. > * gdb.dwarf2/dw2-icc-opaque.exp: New file. Checked in. I had to remove there some 0 bytes as they were producing: readelf: Warning: Bogus end-of-siblings marker detected at offset d0 in .debug_info section readelf: Warning: Bogus end-of-siblings marker detected at offset d1 in .debug_info section readelf: Warning: Bogus end-of-siblings marker detected at offset d2 in .debug_info section readelf: Warning: Further warnings about bogus end-of-sibling markers suppressed Thanks, Jan http://sourceware.org/ml/gdb-cvs/2012-05/msg00186.html - the testcase part: --- src/gdb/testsuite/ChangeLog 2012/05/24 00:33:46 1.3205 +++ src/gdb/testsuite/ChangeLog 2012/05/24 22:09:21 1.3206 @@ -1,3 +1,9 @@ +2012-05-24 John Steele Scott + + PR symtab/13277: Resolving opaque structures in ICC generated binaries. + * gdb.dwarf2/dw2-icc-opaque.S: New file. + * gdb.dwarf2/dw2-icc-opaque.exp: New file. + 2012-05-23 Stan Shebs * gdb.mi/mi-info-os.exp: New file. --- src/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S +++ src/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S 2012-05-24 22:10:03.689886000 +0000 @@ -0,0 +1,207 @@ +/* Copyright (C) 2011-2012 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +/* This test demonstrates a failure to resolve opaque structure types in + binaries compiled by the Intel C compiler. This is GDB PR symtab/13277. + + The test was derived from opaque-pointer.c, which contains the single line: + + struct opaque_struct_t *p_struct; + + and opaque_struct.c, which looks like: + + struct opaque_struct_t + { + int wrapped_value; + }; + + struct opaque_struct_t opaque_internal = { 0 }; + + What follows is a simplified version of the debug info generated by ICC + version 12.0.4.191. */ + + .file "opaque-pointer.c" + .data + .comm p_struct,8,8 + .global p_struct# + + .section .debug_info + .align 1 +debug_info_seg1: + .4byte debug_info_seg1_end - 1f /* Length of compilation unit info. */ +1: + .2byte 0x0002 /* DWARF version number. */ + .4byte .debug_abbrev_seg1 /* Points to abbrev section for this unit. */ + .byte 0x04 /* Target address size. */ + + .byte 0x01 /* DIE 1: DW_TAG_compile_unit. */ + .byte 0x01 /* DW_AT_language = DW_LANG_C89. */ + .ascii "Intel(R) C Intel(R) 64 Compiler XE " /* DW_AT_producer. */ + .ascii "for applications running on Intel(R) 64, " + .ascii "Version 12.0.4.191 Build 20110427\n " + .asciz "Fixes SameLinkageName MemberPointers" + + .byte 0x02 /* DIE 2: DW_TAG_variable. */ + .byte 0x01 /* DW_AT_accessibility. */ + .asciz "p_struct" /* DW_AT_name. */ + .4byte 3f - debug_info_seg1 /* DW_AT_type. */ + .2byte 0x0305 /* DW_AT_location: 5 bytes, DW_OP_addr */ + .4byte p_struct /* followed by the address of p_struct. */ + .byte 0x01 /* DW_AT_external. */ + +3: + .byte 0x03 /* DIE 3: DW_TAG_pointer_type. */ + .4byte 4f - debug_info_seg1 /* DW_AT_type. */ + +4: + .byte 0x04 /* DIE 4: DW_TAG_structure_type. */ + .byte 0x01 /* DW_AT_accessibility. */ + .byte 0x00 /* DW_AT_byte_size. */ + .asciz "opaque_struct_t" /* DW_AT_name. */ + + .byte 0x00 /* End DIE 1. */ +debug_info_seg1_end: + + .section .debug_abbrev +.debug_abbrev_seg1: + .align 1 + .byte 0x01 /* Abbrev 1. */ + .byte 0x11 /* DW_TAG_compile_unit. */ + .byte 0x01 /* DW_CHILDREN_yes. */ + .byte 0x13 /* DW_AT_language. */ + .byte 0x0b /* DW_FORM_data1. */ + .byte 0x25 /* DW_AT_producer. */ + .byte 0x08 /* DW_AT_string. */ + .2byte 0x0000 /* End abbrev. */ + + .byte 0x02 /* Abbrev 2. */ + .byte 0x34 /* DW_TAG_variable. */ + .byte 0x00 /* DW_CHILDREN_no. */ + .byte 0x32 /* DW_AT_accessibility. */ + .byte 0x0b /* DW_FORM_data1. */ + .byte 0x03 /* DW_AT_name. */ + .byte 0x08 /* DW_FORM_string. */ + .byte 0x49 /* DW_AT_type. */ + .byte 0x13 /* DW_FORM_ref4. */ + .byte 0x02 /* DW_AT_location. */ + .byte 0x0a /* DW_FORM_block1. */ + .byte 0x3f /* DW_AT_external. */ + .byte 0x0c /* DW_FORM_flag. */ + .2byte 0x0000 /* End abbrev. */ + + .byte 0x03 /* Abbrev 3. */ + .byte 0x0f /* DW_TAG_pointer_type. */ + .byte 0x00 /* DW_CHILDREN_no. */ + .byte 0x49 /* DW_AT_type. */ + .byte 0x13 /* DW_FORM_ref4. */ + .2byte 0x0000 /* End abbrev. */ + + .byte 0x04 /* Abbrev 4. */ + .byte 0x13 /* DW_TAG_structure_type. */ + .byte 0x00 /* DW_CHILDREN_no. */ + .byte 0x32 /* DW_AT_accessibility. */ + .byte 0x0b /* DW_FORM_data1. */ + .byte 0x0b /* DW_AT_byte_size. */ + .byte 0x0b /* DW_FORM_data1. */ + .byte 0x03 /* DW_AT_name. */ + .byte 0x08 /* DW_FORM_string. */ + .2byte 0x0000 /* End abbrev. */ + .byte 0x00 /* End abbrev table. */ + + + .file "opaque-struct.c" + .section .debug_info + .align 1 +debug_info_seg2: + .4byte debug_info_seg2_end - 1f /* Length of compilation unit info. */ +1: + .2byte 0x0002 /* DWARF version number. */ + .4byte .debug_abbrev_seg2 /* Points to abbrev section for this unit. */ + .byte 0x04 /* Target address size. */ + + .byte 0x01 /* DIE 1: DW_TAG_compile_unit. */ + .byte 0x01 /* DW_AT_language = DW_LANG_C89. */ + .ascii "Intel(R) C Intel(R) 64 Compiler XE " /* DW_AT_producer. */ + .ascii "for applications running on Intel(R) 64, " + .ascii "Version 12.0.4.191 Build 20110427\n " + .asciz "Fixes SameLinkageName MemberPointers" + + .byte 0x02 /* DIE 2: DW_TAG_structure_type. */ + .byte 0x01 /* DW_AT_accessibility. */ + .byte 0x04 /* DW_AT_byte_size. */ + .asciz "opaque_struct_t" /* DW_AT_name. */ + + + .byte 0x03 /* DIE 3: DW_TAG_member. */ + .2byte 0x2302 /* DW_AT_data_member_location, 2 bytes, */ + .byte 0x00 /* DW_OP_plus_uconst followed by zero. */ + .asciz "wrapped_value" /* DW_AT_name. */ + .4byte 4f - debug_info_seg2 /* DW_AT_type. */ + .byte 0x00 + +4: + .byte 0x04 /* DIE 4: DW_TAG_base_type. */ + .byte 0x04 /* DW_AT_byte_size. */ + .byte 0x05 /* DW_AT_encoding. */ + .asciz "int" /* DW_AT_name. */ + + .byte 0x00 /* End DIE 1. */ +debug_info_seg2_end: + + .section .debug_abbrev +.debug_abbrev_seg2: + .align 1 + .byte 0x01 /* Abbrev 1. */ + .byte 0x11 /* DW_TAG_compile_unit. */ + .byte 0x01 /* DW_CHILDREN_yes. */ + .byte 0x13 /* DW_AT_language. */ + .byte 0x0b /* DW_FORM_data1. */ + .byte 0x25 /* DW_AT_producer. */ + .byte 0x08 /* DW_FORM_string. */ + .2byte 0x0000 /* End abbrev. */ + + .byte 0x02 /* Abbrev 2. */ + .byte 0x13 /* DW_TAG_structure_type. */ + .byte 0x01 /* DW_CHILDREN_yes. */ + .byte 0x32 /* DW_AT_accessibility. */ + .byte 0x0b /* DW_FORM_data1. */ + .byte 0x0b /* DW_AT_byte_size. */ + .byte 0x0b /* DW_FORM_data1. */ + .byte 0x03 /* DW_AT_name. */ + .byte 0x08 /* DW_FORM_string. */ + .2byte 0x0000 /* End abbrev. */ + + .byte 0x03 /* Abbrev 3. */ + .byte 0x0d /* DW_TAG_member. */ + .byte 0x00 /* DW_CHILDREN_no. */ + .byte 0x38 /* DW_AT_data_member_location. */ + .byte 0x0a /* DW_FORM_block1. */ + .byte 0x03 /* DW_AT_name. */ + .byte 0x08 /* DW_FORM_string. */ + .byte 0x49 /* DW_AT_type. */ + .byte 0x13 /* DW_FORM_ref4. */ + .2byte 0x0000 /* End abbrev. */ + + .byte 0x04 /* Abbrev 4. */ + .byte 0x24 /* DW_TAG_base_type. */ + .byte 0x00 /* DW_CHILDREN_no. */ + .byte 0x0b /* DW_AT_byte_size. */ + .byte 0x0b /* DW_FORM_data1. */ + .byte 0x3e /* DW_AT_encoding. */ + .byte 0x0b /* DW_FORM_data1. */ + .byte 0x03 /* DW_AT_name. */ + .byte 0x08 /* DW_FORM_string. */ + .2byte 0x0000 /* End abbrev. */ + .byte 0x00 /* End abbrev table. */ --- src/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.exp +++ src/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.exp 2012-05-24 22:10:04.789492000 +0000 @@ -0,0 +1,41 @@ +# Copyright (C) 2011-2012 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . +load_lib dwarf.exp + +# Test that we can correctly resolve opaque structures compiled by the Intel +# compiler, which does not set DW_AT_declaration on opaque structure types. +# This is GDB PR symtab/13277. + +# This test can only be run on targets which support DWARF-2 and use gas. +if {![dwarf2_support]} { + return 0 +} + +set testfile "dw2-icc-opaque" +set srcfile ${testfile}.S +set executable ${testfile}.x +set binfile ${objdir}/${subdir}/${executable} + +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" object {}] != "" } { + return -1 +} + +clean_restart $executable + +# Before PR 13277 was fixed, this would output: +# type = struct opaque_struct_t { +# +# } * +gdb_test "ptype p_struct" "type = struct opaque_struct_t {\r\n *int wrapped_value;\r\n} \\*"