From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-91373-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9902 invoked by alias); 22 May 2012 12:18:51 -0000
Received: (qmail 9889 invoked by uid 22791); 22 May 2012 12:18:49 -0000
X-SWARE-Spam-Status: No, hits=-3.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 May 2012 12:18:37 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id 8EBFC1C6F0A;	Tue, 22 May 2012 08:18:36 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id 0gNaUTn0qeJT; Tue, 22 May 2012 08:18:36 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id C8A131C6F09;	Tue, 22 May 2012 08:18:34 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000)	id CECED145616; Tue, 22 May 2012 05:18:32 -0700 (PDT)
Date: Tue, 22 May 2012 12:18:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: 'Pedro Alves' <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFA-v2/ARI fix] Remove use of abort function in common/buffer.c
Message-ID: <20120522121832.GC5492@adacore.com>
References: <4fbb59b7.44e2440a.48c4.ffffab13SMTPIN_ADDED@mx.google.com> <4FBB5D9B.5070202@redhat.com> <000c01cd3813$32090b40$961b21c0$@muller@ics-cnrs.unistra.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <000c01cd3813$32090b40$961b21c0$@muller@ics-cnrs.unistra.fr>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-05/txt/msg00815.txt.bz2

Hi Pierre, Hi Pedro,

Thanks for taking care of this, Pierre.

> +  /* new_buffer is non NULL otherwise
> +     xrealloc calls malloc_failure which does not return here.  */

I suggest a slightly different way of saying this:

    /* xrealloc guaranties that new_buffer cannot be null.  */

It avoids the problem with the location of the line break and any issue
with punctuation...

-- 
Joel