From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: gdb.base/print-file-var.exp false PASS [Re: [RFA] choose symbol from given block's objfile first.]
Date: Fri, 18 May 2012 16:10:00 -0000 [thread overview]
Message-ID: <20120518161008.GA24465@host2.jankratochvil.net> (raw)
In-Reply-To: <20120509214856.GA8314@adacore.com>
On Wed, 09 May 2012 23:48:56 +0200, Joel Brobecker wrote:
> +++ b/gdb/testsuite/gdb.base/print-file-var-lib1.c
[..]
> +int this_version_id = 104;
> +
> +int
> +get_version_1 (void)
> +{
> + return this_version_id;
> +}
[...]
> +++ b/gdb/testsuite/gdb.base/print-file-var-lib2.c
[...]
> +int this_version_id = 203;
> +
> +int
> +get_version_2 (void)
> +{
> + return this_version_id;
> +}
[...]
> +++ b/gdb/testsuite/gdb.base/print-file-var-main.c
[...]
> +int
> +main (void)
> +{
> + if (get_version_1 () != 104)
> + return 1;
> + if (get_version_2 () != 104)
> + return 2;
> + return 0;
> +}
[...]
> +++ b/gdb/testsuite/gdb.base/print-file-var.exp
[...]
> +gdb_test "print 'print-file-var-lib1.c'::this_version_id" \
> + " = 104"
> +
> +gdb_test "print 'print-file-var-lib2.c'::this_version_id" \
> + " = 203"
This testcase proves GDB behaves incorrectly - if the code sees 104 in both
cases then GDB should also print 104 in both cases. I am curious why did you
check it in when you have proven yourself the regression.
Regards,
Jan
next prev parent reply other threads:[~2012-05-18 16:10 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 22:43 [RFC] choose symbol from given block's objfile first Joel Brobecker
2012-05-08 17:19 ` Tom Tromey
2012-05-09 19:05 ` [RFA] " Joel Brobecker
2012-05-09 19:08 ` Joel Brobecker
2012-05-09 20:15 ` Tom Tromey
2012-05-09 20:40 ` Joel Brobecker
2012-05-09 20:57 ` Tom Tromey
2012-05-09 21:06 ` Joel Brobecker
2012-05-10 13:42 ` Tom Tromey
2012-05-10 16:27 ` checked in: " Joel Brobecker
2012-05-10 17:19 ` Joel Brobecker
2012-05-09 21:48 ` Joel Brobecker
2012-05-09 21:49 ` Joel Brobecker
2012-05-18 16:10 ` Jan Kratochvil [this message]
2012-05-18 17:17 ` gdb.base/print-file-var.exp false PASS [Re: [RFA] choose symbol from given block's objfile first.] Joel Brobecker
2012-05-18 17:37 ` Jan Kratochvil
2012-05-09 20:08 ` [RFA] choose symbol from given block's objfile first Tom Tromey
2012-05-11 7:26 ` Regression for gdb.fortran/library-module.exp [Re: [RFA] choose symbol from given block's objfile first.] Jan Kratochvil
2012-05-11 12:25 ` Joel Brobecker
2012-05-14 14:39 ` Joel Brobecker
2012-05-14 14:52 ` Jan Kratochvil
2012-05-14 15:06 ` Joel Brobecker
2012-05-14 15:15 ` Jan Kratochvil
2012-05-14 16:57 ` Joel Brobecker
2012-05-14 17:05 ` Jan Kratochvil
2012-05-14 17:49 ` Pedro Alves
2012-05-14 17:59 ` Joel Brobecker
2012-05-14 18:07 ` Jan Kratochvil
2012-05-15 13:09 ` Joel Brobecker
2012-05-16 19:57 ` RFC for: "Re: Regression for gdb.fortran/library-module.exp [Re: [RFA] choose symbol from given block's objfile first.]" Joel Brobecker
2012-05-18 17:46 ` Jan Kratochvil
2012-05-28 14:27 ` Joel Brobecker
2012-05-28 16:12 ` Jan Kratochvil
2012-05-29 15:44 ` Joel Brobecker
2012-05-29 15:49 ` Joel Brobecker
2012-05-29 15:56 ` Jan Kratochvil
2012-05-29 16:02 ` Joel Brobecker
2012-05-29 16:12 ` Jan Kratochvil
2012-05-29 16:31 ` Pedro Alves
2012-05-10 14:14 ` [RFC] choose symbol from given block's objfile first Pedro Alves
2012-05-10 14:32 ` Tom Tromey
2012-05-10 14:50 ` Matt Rice
2012-05-10 15:07 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120518161008.GA24465@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox