From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17712 invoked by alias); 14 May 2012 16:24:35 -0000 Received: (qmail 17699 invoked by uid 22791); 14 May 2012 16:24:33 -0000 X-SWARE-Spam-Status: No, hits=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_EG X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 May 2012 16:24:21 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7DF011C68F3; Mon, 14 May 2012 12:24:20 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Tj0DCdBNIm8x; Mon, 14 May 2012 12:24:20 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4D75A1C68B9; Mon, 14 May 2012 12:24:20 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 6C09E145616; Mon, 14 May 2012 09:24:12 -0700 (PDT) Date: Mon, 14 May 2012 16:24:00 -0000 From: Joel Brobecker To: Jeff Kenton Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor (part 1/3: gdb) Message-ID: <20120514162412.GJ10253@adacore.com> References: <4FAD39A1.1000209@tilera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FAD39A1.1000209@tilera.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00518.txt.bz2 > gdb/ > * tilegx-linux-tdep.c: New file > * tilegx-tdep.c: New file > * configure.host: Add tilegx target. > * configure.tgt: Add tilegx target. > * Makefile.in: Add tilegx dependencies. > > gdb/regformats/ > * reg-tilegx.dat: New file. > > gdb/config/tilegx/ > * nm-linux.h: New file. There is something I missed as well: I thought you were submitted both target and native at the same time, but I see now that patch #2 is taking care of the native part. IN that case, I think that the configure.host changes are superfluous, and and nm-linux.h also. These two should be move to patch #2. Can you resubmit patch #2 & #3 after you've clean them up? -- Joel