From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15968 invoked by alias); 12 May 2012 19:38:18 -0000 Received: (qmail 15957 invoked by uid 22791); 12 May 2012 19:38:17 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 12 May 2012 19:37:59 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4CJbttA000693 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 12 May 2012 15:37:55 -0400 Received: from host2.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4CJboR1028698 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sat, 12 May 2012 15:37:53 -0400 Date: Sat, 12 May 2012 19:38:00 -0000 From: Jan Kratochvil To: "Maciej W. Rozycki" Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] MIPS16 FP manual call/return fixes Message-ID: <20120512193750.GA26427@host2.jankratochvil.net> References: <87mx5y70mv.fsf@fleche.redhat.com> <20120501140457.GA1691@host2.jankratochvil.net> <20120502212811.GA22285@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00484.txt.bz2 On Tue, 08 May 2012 16:29:44 +0200, Maciej W. Rozycki wrote: > I have decided to add a related_address field to bp_location; this could > get converted to an opaque member in the future in case some other > breakpoints need to carry other auxiliary information [ Mostly unrelated to this patch: ] This should be C++ inherited class field; or in C it should be bp_location-type driven union. While I would find it cleaner with the union I do not request this as mandatory for check-in, it could also start some new GDB coding style discussions. > (just as we do with some other structures). [ Mostly unrelated to this patch: ] Unfortunately we do but we do not / no longer have to. > I have decided to keep the assertion you had concerns about after all. I meant that 'gdb_assert (is_gnu_ifunc);', that is gone now. > b->type = bp_gnu_ifunc_resolver; [...] > Is it ever possible for this breakpoint to be updated later on with > additional locations? I am not aware of. > --- gdb-fsf-trunk-quilt.orig/gdb/elfread.c 2012-05-08 08:25:37.795639727 +0100 > +++ gdb-fsf-trunk-quilt/gdb/elfread.c 2012-05-08 09:42:32.075560588 +0100 > @@ -1020,21 +1020,15 @@ elf_gnu_ifunc_resolver_return_stop (stru [...] > + CORE_ADDR func_func_addr; This variable is unused now. [...] > --- gdb-fsf-trunk-quilt.orig/gdb/breakpoint.c 2012-05-04 19:26:24.845606346 +0100 > +++ gdb-fsf-trunk-quilt/gdb/breakpoint.c 2012-05-08 08:26:49.855603092 +0100 [...] > @@ -6609,6 +6610,9 @@ set_breakpoint_location_function (struct > /* Create only the whole new breakpoint of this type but do not > mess more complicated breakpoints with multiple locations. */ > b->type = bp_gnu_ifunc_resolver; Empty line before a comment according to GDB Coding Standards. > + /* Remember the resolver's address for use by the return > + breakpoint. */ > + loc->related_address = func_addr; > } > } > [...] OK for the IFUNC part from me. Thanks, Jan