From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 334 invoked by alias); 11 May 2012 20:28:27 -0000 Received: (qmail 321 invoked by uid 22791); 11 May 2012 20:28:24 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 May 2012 20:28:12 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4BKSBMD015703 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 11 May 2012 16:28:12 -0400 Received: from host2.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4BKS8hA022981 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 11 May 2012 16:28:10 -0400 Date: Fri, 11 May 2012 20:28:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: [patch] Cosmetic fix 'show auto-load safe-path' for ":" [Re: [patch 1/2] Provide $ddir substitution for --with-auto-load-safe-path] Message-ID: <20120511202807.GA4333@host2.jankratochvil.net> References: <20120509154640.GA12692@host2.jankratochvil.net> <4FAD56BE.7090703@redhat.com> <20120511181650.GC21798@host2.jankratochvil.net> <4FAD6193.7080905@redhat.com> <20120511190452.GA22417@host2.jankratochvil.net> <4FAD6527.2040800@redhat.com> <20120511193353.GA23461@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120511193353.GA23461@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00449.txt.bz2 On Fri, 11 May 2012 21:33:53 +0200, Jan Kratochvil wrote: > On Fri, 11 May 2012 21:14:47 +0200, Pedro Alves wrote: > > Looks like there is some special casing somewhere: > > True, I forgot and I agree. But it is only this "cosmetic" message, it has no > functionality effect. I can fix this "any directory" message conditional. Regards, Jan gdb/ 2012-05-11 Jan Kratochvil * auto-load.c (show_auto_load_safe_path): Accept any combination of DIRNAME_SEPARATOR and IS_DIR_SEPARATOR for wild-match. diff --git a/gdb/auto-load.c b/gdb/auto-load.c index 5ee117f..462ee06 100644 --- a/gdb/auto-load.c +++ b/gdb/auto-load.c @@ -241,7 +241,15 @@ static void show_auto_load_safe_path (struct ui_file *file, int from_tty, struct cmd_list_element *c, const char *value) { - if (strcmp (value, "/") == 0) + const char *cs; + + /* Check if user has entered either "/" or for example ":". + But while more complicate content like ":/foo" would still also + permit any location do not hide those. */ + + for (cs = value; *cs && (*cs == DIRNAME_SEPARATOR || IS_DIR_SEPARATOR (*cs)); + cs++); + if (*cs == 0) fprintf_filtered (file, _("Auto-load files are safe to load from any " "directory.\n")); else