Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: hjl.tools@gmail.com
Cc: gdb-patches@sourceware.org
Subject: Re: PATCH: Check DS segment register for x32 process
Date: Fri, 11 May 2012 20:25:00 -0000	[thread overview]
Message-ID: <201205112025.q4BKP0fa012403@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20120511193114.GA5097@intel.com> (hongjiu.lu@intel.com)

> Date: Fri, 11 May 2012 12:31:14 -0700
> From: "H.J. Lu" <hongjiu.lu@intel.com>
> 
> Hi,
> 
> This patch checks DS segment register for x32 process.  Tested on
> Linux/x86-64.  OK to install?
> 
> Thanks.
> 
> H.J.
> ---
> 	* amd64-linux-nat.c (AMD64_LINUX_X32_DS): New.
> 	(amd64_linux_read_description): Check DS segment register for
> 	x32 process.
> 
> diff --git a/gdb/amd64-linux-nat.c b/gdb/amd64-linux-nat.c
> index 3be8404..97c9a49 100644
> --- a/gdb/amd64-linux-nat.c
> +++ b/gdb/amd64-linux-nat.c

> +  if (sizeof (void *) == 4 && is_64bit && !is_x32)
> +    error (_("Can't debug 64-bit process with 32-bit GDB"));

I really think we should refuse to even build a GDB as an X32 binary.


  reply	other threads:[~2012-05-11 20:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 19:31 H.J. Lu
2012-05-11 20:25 ` Mark Kettenis [this message]
2012-05-11 20:29   ` H.J. Lu
2012-05-12  3:13   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201205112025.q4BKP0fa012403@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox