From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26579 invoked by alias); 11 May 2012 20:20:30 -0000 Received: (qmail 26521 invoked by uid 22791); 11 May 2012 20:20:28 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,TW_AV,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 May 2012 20:20:14 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id q4BKKCVa010007; Fri, 11 May 2012 22:20:12 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id q4BKKAbT010335; Fri, 11 May 2012 22:20:10 +0200 (CEST) Date: Fri, 11 May 2012 20:20:00 -0000 Message-Id: <201205112020.q4BKKAbT010335@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: hjl.tools@gmail.com CC: gdb-patches@sourceware.org In-reply-to: <20120511192949.GA5070@intel.com> (hongjiu.lu@intel.com) Subject: Re: PATCH: Check bfd_mach_x64_32 to set tdesc for x32 binary References: <20120511192949.GA5070@intel.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00445.txt.bz2 > Hi, > > This patch checks bfd_mach_x64_32 to set tdesc for x32 binary. Tested > on Linux/x86-64. OK to install? > > Thanks. > > > H.J. > --- > * amd64-linux-tdep.c: Include features/i386/x32-linux.c > and features/i386/x32-avx-linux.c. > (amd64_linux_init_abi): Check bfd_mach_x64_32 for x32 process. > (_initialize_amd64_linux_tdep): Register bfd_mach_x64_32. Call > initialize_tdesc_x32_linux and initialize_tdesc_x32_avx_linux. > > * amd64-linux-tdep.h (tdesc_x32_linux): New. > (tdesc_x32_avx_linux): Likewise. > > diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c > index acc7303..601ce20 100644 > --- a/gdb/amd64-linux-tdep.c > +++ b/gdb/amd64-linux-tdep.c > @@ -1545,8 +1578,12 @@ _initialize_amd64_linux_tdep (void) > { > gdbarch_register_osabi (bfd_arch_i386, bfd_mach_x86_64, > GDB_OSABI_LINUX, amd64_linux_init_abi); > + gdbarch_register_osabi (bfd_arch_i386, bfd_mach_x64_32, > + GDB_OSABI_LINUX, amd64_linux_init_abi); Instead of doing this, you should introduce an amd64_x32_linux_init_abi() function, make that call amd64_linix_init_abi() and ovverride the bits that are different for X32.