From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18454 invoked by alias); 11 May 2012 19:54:07 -0000 Received: (qmail 18445 invoked by uid 22791); 11 May 2012 19:54:06 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 May 2012 19:53:47 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4BJrV4u009600 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 11 May 2012 15:53:31 -0400 Received: from host2.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4BJrQR9015579 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 11 May 2012 15:53:29 -0400 Date: Fri, 11 May 2012 19:54:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [patch 1/2] Provide $ddir substitution for --with-auto-load-safe-path Message-ID: <20120511195325.GA23742@host2.jankratochvil.net> References: <20120509154640.GA12692@host2.jankratochvil.net> <4FAD56BE.7090703@redhat.com> <20120511181913.GD5886@adacore.com> <20120511182941.GF21798@host2.jankratochvil.net> <20120511193801.GE5886@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120511193801.GE5886@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00443.txt.bz2 On Fri, 11 May 2012 21:38:01 +0200, Joel Brobecker wrote: > I proposing we ditch safe-path entirely, and merge it with > scripts-directory. What good is it to have a directory in > scripts-directory if it's not in safe-path at the same time? Such case is not useful. But I find useful to have directory in safe-path but not in scripts-directory: Fedora config: --with-auto-load-dir='$ddir/auto-load%{?scl::%{_root_datadir}/gdb/auto-load}' \ --with-auto-load-safe-path='$ddir/auto-load%{?scl::%{_root_datadir}/gdb/auto-load}:/usr/lib/debug:%{_root_bindir}/mono-gdb.py' \ a bit offtopic #1: mono-gdb.py is just a workaround of packaging bug: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=815501 a bit offtopic #2: debug-file-directory is used by GDB implicitly as if it is in scripts-directory (see auto_load_objfile_script, not by me). Maybe we could have introduced $debugdir substitution instead and make it a part of default --with-auto-load-safe-path. So far I find debug-file-directory (and the separate debug info feature) to be distro specific enough it may require such specific configuration of --with-auto-load-safe-path. But with separate --with-auto-load-safe-path one can permit loading .gdbinit from GCC or Emacs build directory: --with-auto-load-safe-path=$ddir/auto-load:~/src/gcc:~/src/emacs If you unify these two settings it will try to load scripts for arbitrary inferiors also from ~/src/gcc and from ~/src/emacs. Which should be safe - as you declared these directories safe - but I find it a bit mess. Not sure if it is simplification or complication. Thanks, Jan