From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6365 invoked by alias); 11 May 2012 16:46:43 -0000 Received: (qmail 6344 invoked by uid 22791); 11 May 2012 16:46:39 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 May 2012 16:46:22 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4BGjpQe021987 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 11 May 2012 12:45:58 -0400 Received: from host2.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4BGYeuP007682 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 11 May 2012 12:34:42 -0400 Date: Fri, 11 May 2012 16:46:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [patch 1/2] Provide $ddir substitution for --with-auto-load-safe-path Message-ID: <20120511163439.GA1674@host2.jankratochvil.net> References: <20120509154640.GA12692@host2.jankratochvil.net> <8362c51ccr.fsf@gnu.org> <20120509185917.GD22045@host2.jankratochvil.net> <20120509200814.GK15555@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120509200814.GK15555@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00417.txt.bz2 On Wed, 09 May 2012 22:08:14 +0200, Joel Brobecker wrote: > It's a nice addition to have the auto-load safe-path relocatable... > > > +--with-auto-load-safe-path > > + Configure default value for the 'set auto-load safe-path' setting > > + above. It defaults to '$ddir/auto-load', $ddir representing the value > > + of configure option --with-gdb-datadir. > > I don't think that this is entirely accurate. $ddir represents the > GDB data dir, whose value can easily be different from the value passed > via --with-gdb-datadir. I would refer to the value of "set > data-directory" instead. I have changed it in the patchset as you are right it is more correct. But in reality user will use either configure option --with-gdb-datadir or the command-line option -data-directory which is why I wrote it that way. Until recently I did not remember how is 'show data-directory' exactly called. But explaining there all of 'show data-directory', --with-gdb-datadir and -data-directory is probably out of the scope of the NEWS file. But I agree it is formally correct now. Thanks, Jan NEWS: - above. It defaults to '$ddir/auto-load', $ddir representing the value - of configure option --with-gdb-datadir. + above. It defaults to '$ddir/auto-load', $ddir representing GDB's + data directory (available via show data-directory). gdb.texinfo: -Any used string @file{$ddir} will get replaced by @var{data-directory} which is -determined at @value{GDBN} startup (@pxref{Data Files}). @file{$ddir} must be +Any used string @file{$ddir} will get replaced by @var{data-directory}, where +@var{data-directory} is @value{GDBN}'s data directory (available via +@code{show data-directory}, @pxref{Data Files}). @file{$ddir} must be