From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20232 invoked by alias); 11 May 2012 07:26:49 -0000 Received: (qmail 20187 invoked by uid 22791); 11 May 2012 07:26:48 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 May 2012 07:26:32 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4B7QA0i031046 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 11 May 2012 03:26:10 -0400 Received: from host2.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4B7Q6YX008807 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 11 May 2012 03:26:09 -0400 Date: Fri, 11 May 2012 07:26:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Regression for gdb.fortran/library-module.exp [Re: [RFA] choose symbol from given block's objfile first.] Message-ID: <20120511072606.GA25458@host2.jankratochvil.net> References: <1336430581-11262-1-git-send-email-brobecker@adacore.com> <874nrqvbeh.fsf@fleche.redhat.com> <20120509190529.GI15555@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120509190529.GI15555@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00397.txt.bz2 On Wed, 09 May 2012 21:05:29 +0200, Joel Brobecker wrote: > gdb/ChangeLog: > > * findvar.c (default_read_var_value): For LOC_UNRESOLVED symbols, > try locating the symbol in the symbol's own objfile first, before > extending the search to all objfiles. > * symtab.c (lookup_symbol_aux_objfile): New function, extracted > out of lookup_symbol_aux_symtabs. > (lookup_symbol_aux_symtabs): Add new parameter "exclude_objfile". > Replace extracted-out code by call to lookup_symbol_aux_objfile. > Do not search EXCLUDE_OBJFILE. > (lookup_static_symbol_aux): Update call to lookup_symbol_aux_symtabs. > (lookup_symbol_global): Search for matches in the block's objfile > first, before searching all other objfiles. > > gdb/testsuite/ChangeLog: > > * gdb.base/ctxobj-f.c, gdb.base/ctxobj-m.c, gdb.base/ctxobj-v.c, > gdb.base/ctxobj.exp: New files. > > Tested on x86_64-linux. No regression. I have different opinion. Running gdb/testsuite/gdb.fortran/library-module.exp ... PASS: gdb.fortran/library-module.exp: continue to breakpoint: i-is-2-in-lib -PASS: gdb.fortran/library-module.exp: print var_i in lib +FAIL: gdb.fortran/library-module.exp: print var_i in lib PASS: gdb.fortran/library-module.exp: continue to breakpoint: i-is-2-in-main -PASS: gdb.fortran/library-module.exp: print var_i in main +FAIL: gdb.fortran/library-module.exp: print var_i in main PASS: gdb.fortran/library-module.exp: print var_j PASS: gdb.fortran/library-module.exp: print var_k 439e2afe4a00ff5f7c07ac033208207e095b1708 is the first bad commit commit 439e2afe4a00ff5f7c07ac033208207e095b1708 Author: Joel Brobecker Date: Thu May 10 16:24:38 2012 +0000 Search global symbols from the expression's block objfile first. Regards, Jan