From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12118 invoked by alias); 9 May 2012 21:06:01 -0000 Received: (qmail 12110 invoked by uid 22791); 9 May 2012 21:06:00 -0000 X-SWARE-Spam-Status: No, hits=0.8 required=5.0 tests=AWL,BAYES_00,KAM_STOCKTIP,RCVD_IN_HOSTKARMA_NO,TW_BJ X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 May 2012 21:05:35 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id EC6081C6AC6; Wed, 9 May 2012 17:05:34 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8uLFAEZbAL85; Wed, 9 May 2012 17:05:34 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BA5461C6AC4; Wed, 9 May 2012 17:05:34 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E04DE145616; Wed, 9 May 2012 14:05:26 -0700 (PDT) Date: Wed, 09 May 2012 21:06:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA] choose symbol from given block's objfile first. Message-ID: <20120509210526.GP15555@adacore.com> References: <1336430581-11262-1-git-send-email-brobecker@adacore.com> <874nrqvbeh.fsf@fleche.redhat.com> <20120509190529.GI15555@adacore.com> <20120509190753.GA31769@adacore.com> <87ehqtru0d.fsf@fleche.redhat.com> <20120509204023.GM15555@adacore.com> <87lil1qdin.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lil1qdin.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00322.txt.bz2 > Joel> There are also some locations where the loop is inside a routine > Joel> that does a lookup without "context". For instance, > Joel> basic_lookup_transparent_type. In that case, the only real caller > Joel> I could find was check_typedef, which I don't think we want to > Joel> change. > > I'm not so sure. It seems like you could make a multi-objfile test case > where an incomplete type is incorrectly resolved to a type in another > objfile. Yeah, I can see now that it should be relatively doable (using opaque types). I'll keep that in mind for a rainy day. I still have to work on enhancing the expresion parser for both C and Ada, as well as that PR that I need to create... If I have a chance today, I'll try to create a testcase that breaks check_typedef. (someone is not looking forward to updating all calls to check_typedef :-)) So, just to be sure: Are we OK with this iteration for now? -- Joel