From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6788 invoked by alias); 9 May 2012 14:17:28 -0000 Received: (qmail 6777 invoked by uid 22791); 9 May 2012 14:17:26 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 May 2012 14:17:12 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1CB161C65B0; Wed, 9 May 2012 10:17:12 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id uguDKm2-TKaw; Wed, 9 May 2012 10:17:12 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id AD1CF1C6358; Wed, 9 May 2012 10:17:11 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2D97B145616; Wed, 9 May 2012 07:17:04 -0700 (PDT) Date: Wed, 09 May 2012 14:17:00 -0000 From: Joel Brobecker To: Tristan Gingold Cc: "Maciej W. Rozycki" , "gdb-patches@sourceware.org ml" Subject: Re: [RFA] Emit a warning for ineffective set VAR = EXP command Message-ID: <20120509141704.GG15555@adacore.com> References: <8781499A-A489-42D0-80B1-75136331DBDB@adacore.com> <20120507193824.GW15555@adacore.com> <419AD66E-6D21-40D6-97FE-1FF387117B7D@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <419AD66E-6D21-40D6-97FE-1FF387117B7D@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00270.txt.bz2 > I don't know who should approve this adjustment, but here is the > version that deals with pre/post inc/dec. Note that it still warns > for expressions such as i++ * 2. I think a warning is fine in this case. "set i++ * 2" almost certainly means something is fishy, because the multiplication is useless. > 2012-05-09 Tristan Gingold > > * printcmd.c (set_command): Add pre/post inc/dec. This looks good to me. Thanks Tristan, -- Joel