Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: joel.sherrill@oarcorp.com
Cc: gdb-patches@sourceware.org
Subject: Re: GDB: Add microblaze-*-rtems*
Date: Tue, 08 May 2012 13:54:00 -0000	[thread overview]
Message-ID: <201205081354.q48DsEIi004621@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <4FA92012.7020905@oarcorp.com> (message from Joel Sherrill on	Tue, 8 May 2012 08:30:58 -0500)

> Date: Tue, 8 May 2012 08:30:58 -0500
> From: Joel Sherrill <joel.sherrill@oarcorp.com>
> 
> OK to apply?
> 
> 2012-05-07  Joel Sherrill <joel.sherrill@oarcorp.com>
> 
>      * configure.tgt (microblaze*-*-rtems*): New target.

Eh, this diff is pretty much pointless isn't it?  It seems that from
GDB's viewpoint, RTEMS is effectively "bare metal".  I could live with
changing the comment if you think "running standalone" isn't accurate
enough, but I don't think we should add redundant patterns like this.

> Index: gdb/configure.tgt
> ===================================================================
> RCS file: /cvs/src/src/gdb/configure.tgt,v
> retrieving revision 1.253
> diff -u -r1.253 configure.tgt
> --- gdb/configure.tgt	24 Apr 2012 03:33:16 -0000	1.253
> +++ gdb/configure.tgt	7 May 2012 20:15:54 -0000
> @@ -331,8 +331,8 @@
>  			monitor.o dsrec.o solib-svr4.o symfile-mem.o linux-tdep.o"
>  	gdb_sim=../sim/microblaze/libsim.a
>  	;;
> -microblaze*-*-*)
> -	# Target: Xilinx MicroBlaze running standalone
> +microblaze*-*-* | microblaze*-*-rtems*)
> +	# Target: Xilinx MicroBlaze running standalone (or RTEMS)
>  	gdb_target_obs="microblaze-tdep.o microblaze-rom.o monitor.o dsrec.o"
>  	gdb_sim=../sim/microblaze/libsim.a
>  	;;


  reply	other threads:[~2012-05-08 13:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-08 13:31 Joel Sherrill
2012-05-08 13:54 ` Mark Kettenis [this message]
2012-05-08 13:57   ` Joel Sherrill
2012-05-15 13:29 ` Michael Eager

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201205081354.q48DsEIi004621@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=joel.sherrill@oarcorp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox