From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8227 invoked by alias); 7 May 2012 19:58:33 -0000 Received: (qmail 8217 invoked by uid 22791); 7 May 2012 19:58:32 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 May 2012 19:58:16 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q47JwFV7023375 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 7 May 2012 15:58:16 -0400 Received: from host2.jankratochvil.net (ovpn-116-17.ams2.redhat.com [10.36.116.17]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q47JwCmG022374 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 7 May 2012 15:58:14 -0400 Date: Mon, 07 May 2012 19:58:00 -0000 From: Jan Kratochvil To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/6] Implement support for SystemTap probes Message-ID: <20120507195811.GA6969@host2.jankratochvil.net> References: <20120507193538.GA6283@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00194.txt.bz2 On Mon, 07 May 2012 21:53:49 +0200, Sergio Durigan Junior wrote: > --- a/gdb/probe.c > +++ b/gdb/probe.c > @@ -303,6 +303,9 @@ collect_probes (char *objname, char *provider, char *probe_name, > if (! objfile->sf || ! objfile->sf->sym_probe_fns) > continue; > > + if (objfile->separate_debug_objfile_backlink != NULL) > + continue; > + I do not think it should be kind-unspecific. Different probe kind can be for example present only in .debug files and not in the main binaries. Also I do not find great that it does not get displayed by `info probes' but other commands still process even probes from .debug files. Couldn't you put this conditional rather into stap_get_probes? Thanks, Jan