From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29047 invoked by alias); 5 May 2012 15:16:17 -0000 Received: (qmail 29037 invoked by uid 22791); 5 May 2012 15:16:15 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 May 2012 15:16:03 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 650C11C6BC2; Sat, 5 May 2012 11:16:02 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id GmSjc2doyPFA; Sat, 5 May 2012 11:16:02 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F002C1C6B8B; Sat, 5 May 2012 11:16:01 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id EDD74145616; Sat, 5 May 2012 08:15:57 -0700 (PDT) Date: Sat, 05 May 2012 15:16:00 -0000 From: Joel Brobecker To: John Steele Scott Cc: Tom Tromey , Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [patch] PR symtab/13277: Resolving opaque structures in ICC generated binaries. (testcase) Message-ID: <20120505151557.GU15555@adacore.com> References: <4E9A6F3C.6010400@toojays.net> <20111019084011.GA9326@host1.jankratochvil.net> <4EA3E995.8040206@toojays.net> <20111026221057.GA24628@host1.jankratochvil.net> <4EBFAC05.2070501@toojays.net> <4FA49314.5020508@toojays.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FA49314.5020508@toojays.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00158.txt.bz2 > Wow, I knew it would take a while, but it seems the papers got stuck > in limbo for several months. :-(. That is just not right. If I had known, I'd have pinged the FSF. > 2012-05-05 John Steele Scott > > PR symtab/13277: Resolving opaque structures in ICC generated binaries. > * gdb.dwarf2/dw2-icc-opaque.S: New file. > * gdb.dwarf2/dw2-icc-opaque.exp: New file. The only issue I spotted with this patch is the copyright year, which needs to include 2012 as well, now. And while we are touching this, why not add a '(C)' as well. I know we're very inconsistent with this, but the the GNU Coding Standard shows it in all their example, and I have a feeling that they would rather we did. So: Copyright (C) 2011-2012 Free etc. Not sure about the use of .asciz or not. We seem to have been using .ascii exclusively so far. Jan might know better whether that's ok. -- Joel