From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-90715-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27710 invoked by alias); 5 May 2012 11:45:32 -0000
Received: (qmail 27701 invoked by uid 22791); 5 May 2012 11:45:31 -0000
X-SWARE-Spam-Status: No, hits=-2.8 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 May 2012 11:45:18 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id q45Biv2A031806;	Sat, 5 May 2012 13:44:57 +0200 (CEST)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id q45Bitv4006357;	Sat, 5 May 2012 13:44:55 +0200 (CEST)
Date: Sat, 05 May 2012 11:45:00 -0000
Message-Id: <201205051144.q45Bitv4006357@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: macro@codesourcery.com
CC: brobecker@adacore.com, gdb-patches@sourceware.org
In-reply-to: <alpine.DEB.1.10.1205050013460.18334@tp.orcam.me.uk>	(macro@codesourcery.com)
Subject: Re: [RFA 1/2] mips: Switch inferior function calls to ON_STACK method.
References: <1336071802-13599-1-git-send-email-brobecker@adacore.com> <1336071802-13599-2-git-send-email-brobecker@adacore.com> <alpine.DEB.1.10.1205032047100.18334@tp.orcam.me.uk> <20120503214933.GJ15555@adacore.com> <alpine.DEB.1.10.1205032325500.18334@tp.orcam.me.uk> <20120504205818.GT15555@adacore.com> <201205042118.q44LIh3p018153@glazunov.sibelius.xs4all.nl> <alpine.DEB.1.10.1205050013460.18334@tp.orcam.me.uk>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-05/txt/msg00157.txt.bz2

> Date: Sat, 5 May 2012 00:25:04 +0100
> From: "Maciej W. Rozycki" <macro@codesourcery.com>
>
> > > +/* Implement the push_dummy_code gdbarch method for mips targets.  */
> > 
> > Perhaps change that comment into:
> > 
> >   /* Implement the "push_dummy_call" gdbarch method.  */
> > 
> > such that it is consistent with the style of comments in rl78-tdep.c
> > and rx-tdep.c and moxie-tdep.c?  The "for mips targets" isn't really
> > adding any information (and might end up accidentally being copied).
> 
>  As per my suggestion I think it makes sense to document any peculiarities 
> of this specific implementation here as well (in this case the safety to 
> use with non-executable stack).

The non-executable stack issue really isn't specific to this
implementation though.  On OpenBSD the stack is non-executable on all
architectures where it is possible (including through a clever trick
on i386).  I haven't tried ON_STACK on all of them, but it works on
all of them.