Re: [RFA/commit] procfs.c: Remove unused functions and make many functions static

Maciej W. Rozycki
2012-05-17T19:26:35Z

On Thu, 17 May 2012, Joel Brobecker wrote:

> Maciej asked:
> > Hmm, here's a dumb question as a followup, following a situation I've
> > just experienced -- can this stuff be needed by anything external on
> > Solaris, similarly to some functions pulled from GDB by libthread_db.so.1
> > from glibc?
>
> Sorry for the delay in answering this. I just couldn't find the time
> to look at it.

No worries, understood, I do pipeline stuff too and put aside less
important bits when I have to.

> I think we will be fine. Usually, implicit callbacks have a specific
> name that ties them to the external shared library that needs those
> callbacks, and the fact that the name of the functions being deleted
> start with the same prefix as the others is a little indicative that
> the odds of them being an implicit callback are small. Regardless,
> I did a little bit of research, and found that, AFAICT, this file
> is only used on sparc/x86/amd64-solaris, mips-irixÂ¬ and alpha-tru64.
> I looked at the extra source files needed by these platforms, and
> none of them indicated that we would open a shared library that might
> call one of these functions. Just for kicks, I tested the patch on
> sparc-solaris using AdaCore's testsuite.

Thanks for doing this extra work; actually I hoped we had someone onboard
with enough experience with this stuff to know the answer offhand. I
didn't intend to put you on this long route, sorry about that.

Maciej