From: Joel Brobecker <brobecker@adacore.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: Invalid segment resister value on x86_64-windows
Date: Wed, 02 May 2012 21:26:00 -0000 [thread overview]
Message-ID: <20120502212612.GB15555@adacore.com> (raw)
In-Reply-To: <201205022044.q42KiQLc021611@glazunov.sibelius.xs4all.nl>
> Hmm, it should be possible to do this without changing any of the
> -tdep.c code, but if you prefer to do it this way, can you rename the
> new field into cs_regnum, change the comment into "Register number for
> %cs", and move it somewhere around the other _regnum variables that
> are already part of the struct? That makes things a bit more
> consistent.
If you prefer, I can do something similar to what we do to handle
the register mapping. Attached is a patch that does that, and only
touches windows *-nat code. Untested for now; will test and add
a ChangeLog if this is your prefered approach.
This can be simplified a little further and have everything done
in windows-nat.c, but it would probably be considered uglier:
include "i386-tdep.h" and "amd64-tdep.h" in windows-nat.c, and
then have a quick check to determine which platform we are, and
then set then implement the segment_register_p function using either
a check on sizeof (void *), or a #ifdef [...] #else [...]...
--
Joel
next prev parent reply other threads:[~2012-05-02 21:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 23:04 Joel Brobecker
2012-05-01 23:04 ` [RFA/commit 1/2] Regenerate the features/i386 target description .c files Joel Brobecker
2012-05-02 6:34 ` Sergio Durigan Junior
2012-05-01 23:05 ` [RFA 2/2] [x86/x86_64] Segment registers are 16 bits long (not 32bits) Joel Brobecker
2012-05-02 0:01 ` [RFA 3/2(+)] Test size of x86/x86_64 segment registers Joel Brobecker
2012-05-02 10:10 ` Invalid segment resister value on x86_64-windows Mark Kettenis
2012-05-02 17:57 ` Joel Brobecker
2012-05-02 20:45 ` Mark Kettenis
2012-05-02 21:26 ` Joel Brobecker [this message]
2012-05-02 21:27 ` Joel Brobecker
2012-05-02 21:50 ` Mark Kettenis
2012-05-02 21:58 ` [WINDOWS/RFC] " Joel Brobecker
2012-05-02 22:10 ` Christopher Faylor
2012-05-02 22:16 ` Christopher Faylor
2012-05-04 18:38 ` checked in: " Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502212612.GB15555@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox